Skip to content

adtelligentBidAdapter-update#14555

Open
PiekharievaK wants to merge 5 commits intoprebid:masterfrom
PiekharievaK:adtelligentBidAdapter-update
Open

adtelligentBidAdapter-update#14555
PiekharievaK wants to merge 5 commits intoprebid:masterfrom
PiekharievaK:adtelligentBidAdapter-update

Conversation

@PiekharievaK
Copy link

Type of change

  • [ x] Updated bidder adapter

Description of change

Update adtelligentBidAdapter add placementPositionInfo

import { config } from '../../src/config.js';
import { BANNER, VIDEO } from '../../src/mediaTypes.js';
import {BANNER, VIDEO} from '../../src/mediaTypes.js';
import {getPlacementPositionUtils} from "../placementPositionInfo/placementPositionInfo.js";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't pass linting in current master, please pull master

@github-actions
Copy link

Tread carefully! This PR adds 6 linter errors (possibly disabled through directives):

  • libraries/adtelligentUtils/adtelligentUtils.js (+4 errors)
  • modules/adtelligentBidAdapter.js (+2 errors)

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 23005492004

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 96.357%

Files with Coverage Reduction New Missed Lines %
test/spec/modules/id5AnalyticsAdapter_spec.js 1 96.13%
Totals Coverage Status
Change from base Build 23003483987: 0.0%
Covered Lines: 218283
Relevant Lines: 226535

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants