HypeLab Bid Adapter: Migrate to OpenRTB endpoint#14562
HypeLab Bid Adapter: Migrate to OpenRTB endpoint#14562Minebomber wants to merge 1 commit intoprebid:masterfrom
Conversation
Migrate HypeLab bid adapter from custom /v1/prebid_requests format to OpenRTB 2.6-compliant /v1/rtb_requests endpoint using Prebid's built-in ortbConverter. Remove legacy event reporting callbacks (onTimeout, onSetTargeting, onBidderError); keep onBidWon to fire burl pixel.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| source: "prebid", | ||
| sdk_version: PREBID_VERSION, | ||
| provider_version: PROVIDER_VERSION, | ||
| dpr: typeof window !== "undefined" ? window.devicePixelRatio : 1, |
Check warning
Code scanning / CodeQL
Use of browser API associated with fingerprinting Warning
| method: "POST", | ||
| url: ENDPOINT_URL, | ||
| data: converter.toORTB({ bidRequests: [bidRequest], bidderRequest }), | ||
| options: { contentType: "application/json", withCredentials: true }, |
Check warning
Code scanning / CodeQL
Application/json request type in bidder Warning
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af18dcbe15
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
| user: { | ||
| buyeruid: userId, | ||
| id: userId, |
There was a problem hiding this comment.
The ORTB builder already starts from bidderRequest.ortb2, but this assignment unconditionally replaces user.id with the adapter-derived userId (or a generated tmp_* ID). In setups where publishers provide ortb2.user.id but do not provide userIdAsEids, this drops a stable first-party identifier and replaces it with a per-request random value, which can reduce identity match quality and bidding performance; preserve an existing request.user.id and only set buyeruid/fallback IDs when needed.
Useful? React with 👍 / 👎.
| return bidRequests.map((bidRequest) => ({ | ||
| method: "POST", | ||
| url: ENDPOINT_URL, | ||
| data: converter.toORTB({ bidRequests: [bidRequest], bidderRequest }), |
There was a problem hiding this comment.
By routing request construction entirely through converter.toORTB(...), the adapter no longer carries forward the previous fallback that read bid.params.bidFloor when no getFloor() function was present. Since ORTB bidfloor population depends on getFloor (typically from the floors module), deployments that rely on static params.bidFloor without that module will stop signaling floors after this migration, allowing bids below the intended minimum.
Useful? React with 👍 / 👎.
Pull Request Test Coverage Report for Build 22787418921Details
💛 - Coveralls |
2 participants
Type of change
Description of change
Our old
v1/ad_requestsendpoint was deprecated and this change to our bidding adapter uses the new request endpointv1/rtb_requests, which follows the OpenRTB 2.6 spec. We updated the adapter to use the builtinortbConverterutil to simplify a lot of the old logic related to building requests & parsing responses while retaining our required parameters in theextfields. This change has no outward effects on publishers as the integration requirements remain the same (property_slug,placement_slug).