PixFuture adapter update added VIDEO format#14582
PixFuture adapter update added VIDEO format#14582Arthur482 wants to merge 7 commits intoprebid:masterfrom
Conversation
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7009c40efb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| export const spec = { | ||
| code: 'pixfuture', | ||
| supportedMediaTypes: [BANNER, VIDEO], |
There was a problem hiding this comment.
Declaring VIDEO in supportedMediaTypes makes this adapter eligible for video traffic, but isBidRequestValid still requires bid.sizes, so video bids without an explicit size are dropped before request building. Prebid allows video configs where mediaTypes.video.playerSize is absent, and this adapter already has a fallback size path in bidToTag, so this validation gate blocks otherwise valid video auctions.
Useful? React with 👍 / 👎.
Pull Request Test Coverage Report for Build 23013630807Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
3 participants
Type of change
Description of change
Added support for serving VAST video ads in the Pixfuture bidder adapter.
Key changes
interpretResponseto properly process both banner and video creatives.vastXml) for video bids.This update enables Pixfuture to participate in Prebid video auctions and return VAST creatives that can be rendered by video players such as Google IMA.