Skip to content

Core: allow vast xml without using cache#14611

Merged
patmmccann merged 2 commits intomasterfrom
mkomorski/vast-only
Mar 19, 2026
Merged

Core: allow vast xml without using cache#14611
patmmccann merged 2 commits intomasterfrom
mkomorski/vast-only

Conversation

@mkomorski
Copy link
Collaborator

@mkomorski mkomorski commented Mar 18, 2026

Introduces new flag cache.allowVastXmlOnly which removes obligation of using cache (local or remote) with video bids

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

fixes #14509

@mkomorski mkomorski marked this pull request as ready for review March 18, 2026 14:35
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 23249867750

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 96.344%

Files with Coverage Reduction New Missed Lines %
modules/adxpremiumAnalyticsAdapter.js 1 83.19%
Totals Coverage Status
Change from base Build 23229096016: 0.001%
Covered Lines: 215926
Relevant Lines: 224120

💛 - Coveralls

Copy link
Collaborator

@monis0395 monis0395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patmmccann patmmccann merged commit 6896fee into master Mar 19, 2026
112 checks passed
@patmmccann patmmccann deleted the mkomorski/vast-only branch March 19, 2026 17:01
@karimMourra
Copy link
Collaborator

Thanks @mkomorski !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove obligation to use Cache for Video Bids containing Vast XML

6 participants