Jixie adaptor keyvalues rework#14614
Open
jxdeveloper1 wants to merge 52 commits intoprebid:masterfrom
Open
Conversation
…6650 added response comment and some trivial code.
added a space behind the // in comments
…ain in unit tests
* jixie_add_keyword_frompage: added the code to get the keywords from the meta tags if available.
merge up to origin's master
take latest from upstream
merge up to latest in opensrc prebidjs
* master: (107 commits) Increment version to 8.11.0-pre Prebid 8.10.0 release add privacyIcon to not native asset list (prebid#10259) gppControl_usstates: activity controls for US state consent (prebid#10283) UserID: check for all consent (not just GDPR) to check if an ID needs refreshing (prebid#10286) fluct Bid Adapter: add user.data to bid requests (prebid#10318) Prebid Server adapter: improve cookie_sync tests, check GPP fields are populated (prebid#10362) fix: consolidate banner format array (prebid#10365) consentManagementGpp: support GPP 1.1 (prebid#10282) Relay Bid Adapter : Initial Release (prebid#10197) Yieldmo Bid Adapter : adding 4.x VAST protocol support (prebid#10363) Cadent Aperture MX Bid Adapter: support GPP and GPP Section Ids (prebid#10342) identityLinkSubmodule: add additional check on retrieving the envelope (prebid#10355) fluct Bid Adapter: add gpid to bid requests (prebid#10361) Increment version to 8.10.0-pre Prebid 8.9.0 release fledgeForGpt: consolidate publisher configuration (prebid#10360) ConcertBidAdapter: Add `browserLanguage` to request `meta` object (prebid#10356) GrowthCode Analytics: Updates/BugFixes (prebid#10339) Activity Controls GPP: invalidate covered = 0 in mspa (prebid#10354) ...
* rw-jixie-pass-gpid-etc: sending gpid; sending a few more ids from first party cookie
merge up to upstream master
…e of the 1st party cookies that we want to send to backend
* rw-jixie-get-floor-etc: sending floor to our backend for each bid, when available, changed one of the 1st party cookies that we want to send to backend
merge up to upstream
…bject to determine what ids to read from cookie and to send 2/ removed ontimeout handling 3/ bidwon just ping the trackingUrl, if any 4/ misc: sending aid (from jixie config if any), prebid version etc
* rw-jixie-ids-and-misc: 1/ provide the possibility of using the jixie section of the config object to determine what ids to read from cookie and to send 2/ removed ontimeout handling 3/ bidwon just ping the trackingUrl, if any 4/ misc: sending aid (from jixie config if any), prebid version etc
merge to latest in the opensrc code
merge up to latest from upstream
# Conflicts: # test/spec/modules/jixieIdSystem_spec.js
merge up to upstream master
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b5fb50fe9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
modules/jixieBidAdapter.js
Outdated
Comment on lines
+221
to
+222
| const siteKvs = deepAccess(bidderRequest, 'ortb2.site.ext.data.jixie'); | ||
| const userKvs = deepAccess(bidderRequest, 'ortb2.user.ext.data.jixie'); |
There was a problem hiding this comment.
Prebid already merges bidder-specific ORTB2 into bidderRequest.ortb2 before buildRequests runs (src/adapterManager.ts:533-595), so when a publisher configures Jixie-specific first-party data via setBidderConfig, those values normally live at site.ext.data / user.ext.data. Restricting the lookup to ...data.jixie silently drops that standard bidder-scoped data, so siteKvs/userKvs never get sent unless publishers add an extra, undocumented jixie wrapper inside ext.data.
Useful? React with 👍 / 👎.
Collaborator
Pull Request Test Coverage Report for Build 23274275286Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
sending site and/or user blobl jixie-related key values to jixie endpoint