Open
Conversation
aryehlev
changed the title
Author
|
@bsardo you think you will get to it anytime soon? |
Contributor
|
Hi @aryehlev, we might have some time next week to give this a look. |
guscarreon
reviewed
Mar 20, 2025
| @@ -0,0 +1,166 @@ | |||
| package usptx | |||
There was a problem hiding this comment.
I believe there's a typo on this file's name. Did you mean usptx.go instead of uxptx.go?
| SectionUSPUT SectionID = 11 | ||
| SectionUSPCT SectionID = 12 | ||
| SectionUSPTX SectionID = 16 | ||
| SectionUSPOR SectionID = 15 |
There was a problem hiding this comment.
It is mentioned in the pull request title that Colorado is added but, files sections/uspor/uspor.go and sections/uspor/uspor_test.go as well as this constant's name, seem to hint that the two-letter state code refers to Oregon. Is the pull request title incorrect?
| 11: "usput", | ||
| 12: "uspct", | ||
| 16: "usptx", | ||
| 15: "uspor", |
There was a problem hiding this comment.
Is an entry for Montana missing?
29 12: "uspct",
30 16: "usptx",
+ 14: "uspmt",
31 15: "uspor",
32 }
constants/constants.go
Also, can we sort in descending order?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.