-
Notifications
You must be signed in to change notification settings - Fork 224
Test: Buyeruid scrubbed metric #3692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
osulzhenko
merged 3 commits into
buyeruid-scrubbed-metric
from
qaa/buyeruid-scrubbed-metric
Jan 24, 2025
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -960,4 +960,89 @@ class GdprAuctionSpec extends PrivacyBaseSpec { | |
| null | BULGARIA | null | null | [:] | ||
| null | null | null | null | [:] | ||
| } | ||
|
|
||
| def "PBS auction should update buyeruid scrubbed metrics when user.buyeruid requested"() { | ||
| given: "Default bid requests with personal data" | ||
| def tcfConsent = new TcfConsent.Builder().build() | ||
| def bidRequest = bidRequestWithPersonalData.tap { | ||
| regs.gdpr = 1 | ||
| user.ext.consent = tcfConsent | ||
| ext.prebid.trace = VERBOSE | ||
| } | ||
|
|
||
| and: "Save account config with requireConsent into DB" | ||
| def purposes = [(P2): new PurposeConfig(enforcePurpose: NO, enforceVendors: false)] | ||
| def accountGdprConfig = new AccountGdprConfig(purposes: purposes) | ||
| def account = getAccountWithGdpr(bidRequest.accountId, accountGdprConfig) | ||
| accountDao.save(account) | ||
|
|
||
| and: "Flush metric" | ||
| flushMetrics(privacyPbsService) | ||
|
|
||
| when: "PBS processes auction requests" | ||
| privacyPbsService.sendAuctionRequest(bidRequest) | ||
|
|
||
| then: "Bidder request should mask user personal data" | ||
| def bidderRequest = bidder.getBidderRequest(bidRequest.id) | ||
| verifyAll(bidderRequest.user) { | ||
| !id | ||
| !buyeruid | ||
| !yob | ||
| !gender | ||
| !eids | ||
| !data | ||
| !geo | ||
| !ext | ||
| !eids | ||
| !ext?.eids | ||
| } | ||
|
|
||
| and: "Metrics buyeruid scrubbed should be updated" | ||
| def metrics = privacyPbsService.sendCollectedMetricsRequest() | ||
| assert metrics["adapter.${GENERIC.value}.requests.buyeruid_scrubbed"] == 1 | ||
| assert metrics["account.${account.uuid}.adapter.${GENERIC.value}.requests.buyeruid_scrubbed"] == 1 | ||
|
||
| } | ||
|
|
||
| def "PBS auction shouldn't update buyeruid scrubbed metrics when user.buyeruid not requested"() { | ||
| given: "Default bid requests with personal data" | ||
| def tcfConsent = new TcfConsent.Builder().build() | ||
| def bidRequest = bidRequestWithPersonalData.tap { | ||
| regs.gdpr = 1 | ||
| user.ext.consent = tcfConsent | ||
| user.buyeruid = null | ||
| ext.prebid.trace = VERBOSE | ||
| } | ||
|
|
||
| and: "Save account config with requireConsent into DB" | ||
| def purposes = [(P2): new PurposeConfig(enforcePurpose: NO, enforceVendors: false)] | ||
| def accountGdprConfig = new AccountGdprConfig(purposes: purposes) | ||
| def account = getAccountWithGdpr(bidRequest.accountId, accountGdprConfig) | ||
| accountDao.save(account) | ||
|
|
||
| and: "Flush metric" | ||
| flushMetrics(privacyPbsService) | ||
|
|
||
| when: "PBS processes auction requests" | ||
| privacyPbsService.sendAuctionRequest(bidRequest) | ||
|
|
||
| then: "Bidder request should mask user personal data" | ||
| def bidderRequest = bidder.getBidderRequest(bidRequest.id) | ||
| verifyAll(bidderRequest.user) { | ||
| !id | ||
| !buyeruid | ||
| !yob | ||
| !gender | ||
| !eids | ||
| !data | ||
| !geo | ||
| !ext | ||
| !eids | ||
| !ext?.eids | ||
| } | ||
|
|
||
| and: "Metrics buyeruid scrubbed shouldn't be updated" | ||
| def metrics = privacyPbsService.sendCollectedMetricsRequest() | ||
| assert !metrics["adapter.${GENERIC.value}.requests.buyeruid_scrubbed"] | ||
| assert !metrics["account.${account.uuid}.adapter.${GENERIC.value}.requests.buyeruid_scrubbed"] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ import org.prebid.server.functional.model.config.AccountCoopSyncConfig | |
| import org.prebid.server.functional.model.config.AccountDsaConfig | ||
| import org.prebid.server.functional.model.config.AccountGdprConfig | ||
| import org.prebid.server.functional.model.config.AccountGppConfig | ||
| import org.prebid.server.functional.model.config.AccountMetricsConfig | ||
| import org.prebid.server.functional.model.config.AccountPrivacyConfig | ||
| import org.prebid.server.functional.model.config.Purpose | ||
| import org.prebid.server.functional.model.db.Account | ||
|
|
@@ -38,6 +39,7 @@ import spock.lang.Shared | |
|
|
||
| import static org.prebid.server.functional.model.bidder.BidderName.GENERIC | ||
| import static org.prebid.server.functional.model.bidder.BidderName.OPENX | ||
| import static org.prebid.server.functional.model.config.AccountMetricsVerbosityLevel.DETAILED | ||
|
||
| import static org.prebid.server.functional.model.config.PurposeEnforcement.BASIC | ||
| import static org.prebid.server.functional.model.config.PurposeEnforcement.FULL | ||
| import static org.prebid.server.functional.model.config.PurposeEnforcement.NO | ||
|
|
@@ -263,7 +265,8 @@ abstract class PrivacyBaseSpec extends BaseSpec { | |
| } | ||
|
|
||
| private static Account getAccountWithPrivacy(String accountId, AccountPrivacyConfig privacy) { | ||
| new Account(uuid: accountId, config: new AccountConfig(privacy: privacy)) | ||
| def metricsConfig = new AccountMetricsConfig(verbosityLevel: DETAILED) | ||
| new Account(uuid: accountId, config: new AccountConfig(privacy: privacy, metrics: metricsConfig)) | ||
| } | ||
|
|
||
| protected static Account getAccountWithAllowActivitiesAndPrivacyModule(String accountId, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.