Skip to content

Yieldlab Bidder: Forward consent under param gdpr_consent #3720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 5 commits into from
Feb 10, 2025
Merged

Yieldlab Bidder: Forward consent under param gdpr_consent #3720

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f0ec644
Yieldlab Bidder: Forward consent under param gdpr_consent
AntoxaAntoxic Jan 31, 2025
8624555
Port other differences
AntoxaAntoxic Feb 5, 2025
c54b4c1
Small fix
AntoxaAntoxic Feb 5, 2025
62e96a5
Fix comments
AntoxaAntoxic Feb 6, 2025
6ba22ee
fix comments
AntoxaAntoxic Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/prebid/server/bidder/yieldlab/YieldlabBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ private String makeUrl(ExtImpYieldlab extImpYieldlab, BidRequest request) {

final String consent = getConsentParameter(request.getUser());
if (StringUtils.isNotBlank(consent)) {
uriBuilder.addParameter("consent", consent);
uriBuilder.addParameter("gdpr_consent", consent);
}

extractDsaRequestParamsFromBidRequest(request).forEach(uriBuilder::addParameter);
Expand Down Expand Up @@ -500,7 +500,7 @@ private String makeNurl(BidRequest bidRequest, ExtImpYieldlab extImpYieldlab, Yi
final String consent = getConsentParameter(bidRequest.getUser());
if (StringUtils.isNotBlank(gdpr) && StringUtils.isNotBlank(consent)) {
uriBuilder.addParameter("gdpr", gdpr)
.addParameter("consent", consent);
.addParameter("gdpr_consent", consent);
}

return AD_SOURCE_URL.formatted(
Expand Down
6 changes: 3 additions & 3 deletions src/test/java/org/prebid/server/bidder/yieldlab/YieldlabBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public void makeHttpRequestsShouldSendRequestToModifiedUrlWithHeaders() {
.allSatisfy(uri -> {
assertThat(uri).startsWith("https://test.endpoint.com/1?content=json&pvid=true&ts=");
assertThat(uri).endsWith("&t=key1%3Dvalue1%26key2%3Dvalue2&sizes=1%3A1%7C1%2C1%3A2%7C2&"
+ "ids=buyeruid&yl_rtb_ifa&yl_rtb_devicetype=1&gdpr=1&consent=consent");
+ "ids=buyeruid&yl_rtb_ifa&yl_rtb_devicetype=1&gdpr=1&gdpr_consent=consent");
final String ts = uri.substring(54, uri.indexOf("&t="));
assertThat(Long.parseLong(ts)).isEqualTo(expectedTime);
});
Expand Down Expand Up @@ -193,7 +193,7 @@ public void constructExtImpShouldWorkWithDuplicateKeysTargeting() {
.allSatisfy(uri -> {
assertThat(uri).startsWith("https://test.endpoint.com/1,2?content=json&pvid=true&ts=");
assertThat(uri).endsWith("&t=key1%3Dvalue1&ids=buyeruid&yl_rtb_ifa&"
+ "yl_rtb_devicetype=1&gdpr=1&consent=consent");
+ "yl_rtb_devicetype=1&gdpr=1&gdpr_consent=consent");
});
}

Expand Down Expand Up @@ -245,7 +245,7 @@ public void makeBidsShouldReturnCorrectBidderBid() throws JsonProcessingExceptio
final int weekNumber = Calendar.getInstance().get(Calendar.WEEK_OF_YEAR);
final String adm = """
<script src="https://ad.yieldlab.net/d/1/2/728x90?ts=%s\
&id=extId&pvid=40cb3251-1e1e-4cfd-8edc-7d32dc1a21e5&ids=buyeruid&gdpr=1&consent=consent">\
&id=extId&pvid=40cb3251-1e1e-4cfd-8edc-7d32dc1a21e5&ids=buyeruid&gdpr=1&gdpr_consent=consent">\
</script>""".formatted(timestamp);
final BidderBid expected = BidderBid.of(
Bid.builder()
Expand Down
Loading