Skip to content

Greenbids: Populate AppliedTo and change structure of analytics results in Analytics Tag #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 9 commits into from
Feb 20, 2025
Merged

Greenbids: Populate AppliedTo and change structure of analytics results in Analytics Tag #3728

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e8c671a
Greenbids: Populate AppliedTo in Analytics Tag
EvgeniiMunin Feb 5, 2025
3e356bf
refactor
EvgeniiMunin Feb 5, 2025
1e23162
fix review
EvgeniiMunin Feb 6, 2025
9d6642a
fix review
EvgeniiMunin Feb 7, 2025
da98965
fix review
EvgeniiMunin Feb 7, 2025
ad4a945
cover cases all bidders filterd/ all imps filtered
EvgeniiMunin Feb 17, 2025
0f6a7c2
fixes
EvgeniiMunin Feb 18, 2025
cbadfaa
fixes
EvgeniiMunin Feb 18, 2025
f69646f
fixes
EvgeniiMunin Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ...prebid/server/hooks/modules/greenbids/real/time/data/core/GreenbidsInvocationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,17 @@ public GreenbidsInvocationResult createGreenbidsInvocationResult(
final String greenbidsId = UUID.randomUUID().toString();
final boolean isExploration = isExploration(greenbidsConfig, greenbidsId);

boolean allImpsRejected = impsBiddersFilterMap.values().stream()
.allMatch(biddersMapp -> biddersMapp.values().stream().noneMatch(isKept -> isKept));
final List<Imp> updatedImps = updateImps(bidRequest, impsBiddersFilterMap);

BidRequest updatedBidRequest = (isExploration || allImpsRejected)
BidRequest updatedBidRequest = (isExploration || updatedImps.isEmpty())
? bidRequest
: bidRequest.toBuilder()
.imp(updateImps(bidRequest, impsBiddersFilterMap))
.imp(updatedImps)
.build();
InvocationAction invocationAction = isExploration
? InvocationAction.no_action
: InvocationAction.update;
invocationAction = allImpsRejected ? InvocationAction.reject : invocationAction;
invocationAction = updatedImps.isEmpty() ? InvocationAction.reject : invocationAction;

final Map<String, Ortb2ImpExtResult> ort2ImpExtResultMap = createOrtb2ImpExtForImps(
bidRequest, impsBiddersFilterMap, greenbidsId, isExploration);
Expand All @@ -69,8 +68,8 @@ private List<Imp> updateImps(BidRequest bidRequest, Map<String, Map<String, Bool
}

private boolean isImpKept(Imp imp, Map<String, Map<String, Boolean>> impsBiddersFilterMap) {
Map<String, Boolean> biddersMap = impsBiddersFilterMap.get(imp.getId());
return biddersMap != null && biddersMap.values().stream().anyMatch(isKept -> isKept);
final Map<String, Boolean> biddersMap = impsBiddersFilterMap.get(imp.getId());
return biddersMap.values().stream().anyMatch(isKept -> isKept);
}

private Imp updateImp(Imp imp, Map<String, Boolean> bidderFilterMap) {
Expand Down
Loading