New adapter: Connektai - Xeworks alias #3730 #3738
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| package org.prebid.server.it; | ||
|
|
||
| import io.restassured.response.Response; | ||
| import org.json.JSONException; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.prebid.server.model.Endpoint; | ||
|
|
||
| import java.io.IOException; | ||
|
|
||
| import static com.github.tomakehurst.wiremock.client.WireMock.aResponse; | ||
| import static com.github.tomakehurst.wiremock.client.WireMock.equalTo; | ||
| import static com.github.tomakehurst.wiremock.client.WireMock.equalToJson; | ||
| import static com.github.tomakehurst.wiremock.client.WireMock.post; | ||
| import static com.github.tomakehurst.wiremock.client.WireMock.urlPathEqualTo; | ||
| import static java.util.Collections.singletonList; | ||
|
|
||
| public class ConnektaiTest extends IntegrationTest { | ||
|
|
||
| @Test | ||
| public void openrtb2AuctionShouldRespondWithBidsFromConnektai() throws IOException, JSONException { | ||
| // given | ||
| WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/connektai-exchange")) | ||
| .withQueryParam("host", equalTo("envValue")) | ||
| .withQueryParam("sourceId", equalTo("pidValue")) | ||
| .withRequestBody(equalToJson( | ||
| jsonFrom("openrtb2/connektai/test-connektai-bid-request.json"))) | ||
| .willReturn(aResponse().withBody( | ||
| jsonFrom("openrtb2/connektai/test-connektai-bid-response.json")))); | ||
|
|
||
| // when | ||
| final Response response = responseFor("openrtb2/connektai/test-auction-connektai-request.json", | ||
| Endpoint.openrtb2_auction); | ||
|
|
||
| // then | ||
| assertJsonEquals("openrtb2/connektai/test-auction-connektai-response.json", response, | ||
| singletonList("connektai")); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "id": "request_id", | ||
| "imp": [ | ||
| { | ||
| "id": "imp_id", | ||
| "banner": { | ||
| "w": 300, | ||
| "h": 250 | ||
| }, | ||
| "ext": { | ||
| "connektai": { | ||
| "env": "envValue", | ||
| "pid": "pidValue" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "tmax": 5000, | ||
| "regs": { | ||
| "ext": { | ||
| "gdpr": 0 | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "id": "request_id", | ||
| "seatbid": [ | ||
| { | ||
| "bid": [ | ||
| { | ||
| "id": "bid_id", | ||
| "impid": "imp_id", | ||
| "exp": 300, | ||
| "price": 11.393, | ||
| "adm": "some adm value", | ||
| "adomain": [ | ||
| ], | ||
| "crid": "test-creative-id-1", | ||
| "ext": { | ||
| "prebid": { | ||
| "type": "banner" | ||
| }, | ||
| "origbidcpm": 10, | ||
| "origbidcur": "EUR" | ||
| } | ||
| } | ||
| ], | ||
| "seat": "connektai", | ||
| "group": 0 | ||
| } | ||
| ], | ||
| "cur": "USD", | ||
| "ext": { | ||
| "responsetimemillis": { | ||
| "connektai": "{{ connektai.response_time_ms }}" | ||
| }, | ||
| "tmaxrequest": 5000, | ||
| "prebid": { | ||
| "auctiontimestamp": 0 | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| { | ||
| "id": "request_id", | ||
| "imp": [ | ||
| { | ||
| "id": "imp_id", | ||
| "secure": 1, | ||
| "banner": { | ||
| "w": 300, | ||
| "h": 250 | ||
| }, | ||
| "ext": { | ||
| "tid": "${json-unit.any-string}", | ||
| "bidder": { | ||
| "env": "envValue", | ||
| "pid": "pidValue" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "source": { | ||
| "tid": "${json-unit.any-string}" | ||
| }, | ||
| "site": { | ||
| "domain": "www.example.com", | ||
| "page": "http://www.example.com", | ||
| "publisher": { | ||
| "domain": "example.com" | ||
| }, | ||
| "ext": { | ||
| "amp": 0 | ||
| } | ||
| }, | ||
| "device": { | ||
| "ua": "userAgent", | ||
| "ip": "193.168.244.1" | ||
| }, | ||
| "at": 1, | ||
| "tmax": "${json-unit.any-number}", | ||
| "regs": { | ||
| "ext": { | ||
| "gdpr": 0 | ||
| } | ||
| }, | ||
| "cur": [ | ||
| "USD" | ||
| ], | ||
| "ext": { | ||
| "prebid": { | ||
| "server": { | ||
| "externalurl": "http://localhost:8080", | ||
| "gvlid": 1, | ||
| "datacenter": "local", | ||
| "endpoint": "/openrtb2/auction" | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "id": "request_id", | ||
| "seatbid": [ | ||
| { | ||
| "bid": [ | ||
| { | ||
| "id": "bid_id", | ||
| "impid": "imp_id", | ||
| "adm": "some adm value", | ||
| "price": 10, | ||
| "adomain": [], | ||
| "crid": "test-creative-id-1", | ||
| "ext": { | ||
| "prebid": { | ||
| "type": "banner" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "cur": "EUR" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to test this. It is already tested in the unit tests for the base bidder. We write integration tests only to check that the configurations are correct and that the simplest request will pass from request to response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this because @AntoxaAntoxic said to do it.
Okey, I understand. So where should I check if, for example, in a YAML file, we have two fields, but only one is required, such as placementId? Should I write the tests here?