Skip to content

Conversation

@sangarbe
Copy link
Contributor

@sangarbe sangarbe commented Apr 16, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?
#3787

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@sangarbe sangarbe changed the title Port Seedtag: New Adapter New Adapter: Seedtag Apr 16, 2025
@osulzhenko osulzhenko requested a review from CTMBNara April 22, 2025 09:46
@sangarbe sangarbe requested a review from CTMBNara April 25, 2025 14:16
@sangarbe
Copy link
Contributor Author

sangarbe commented May 5, 2025

Hi @CTMBNara I fixed everything you mentioned on the first review. Just let me know how I can help ;)

@AntoxaAntoxic AntoxaAntoxic linked an issue May 9, 2025 that may be closed by this pull request
@sangarbe sangarbe force-pushed the LN-2831-create-prebid-server-adapter-java branch from 5ab22b3 to 74f6a25 Compare May 13, 2025 08:23
@sangarbe sangarbe requested a review from AntoxaAntoxic May 13, 2025 08:24
@sangarbe
Copy link
Contributor Author

@AntoxaAntoxic I did the change you suggested on the unit tests and also fixed the integration test that failed on the CI workflow. Please take a look and let me know if anything else requires my attention.

AntoxaAntoxic
AntoxaAntoxic previously approved these changes May 13, 2025
@sangarbe
Copy link
Contributor Author

Hi there @CTMBNara and @osulzhenko ! Any possibility to have a second approval soon? I'm sorry to bother you, we have important clients waiting for our adapter to be released.

@sangarbe
Copy link
Contributor Author

@CTMBNara I fixed the linting issue you pointed out on the test, @AntoxaAntoxic I dismissed you review due to the last commit with the commented change. Can you review again?

@CTMBNara CTMBNara merged commit fc6a3c1 into prebid:master May 16, 2025
8 checks passed
osulzhenko pushed a commit that referenced this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: New Adapter: Seedtag

3 participants