-
Notifications
You must be signed in to change notification settings - Fork 224
New Adapter: Seedtag #3916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adapter: Seedtag #3916
Conversation
src/main/java/org/prebid/server/bidder/seedtag/SeedtagBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/seedtag/SeedtagBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/seedtag/SeedtagBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/seedtag/SeedtagBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/seedtag/SeedtagBidder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/seedtag/SeedtagBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/seedtag/SeedtagBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/seedtag/SeedtagBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/seedtag/SeedtagBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/resources/org/prebid/server/it/test-application.properties
Outdated
Show resolved
Hide resolved
|
Hi @CTMBNara I fixed everything you mentioned on the first review. Just let me know how I can help ;) |
src/test/java/org/prebid/server/bidder/seedtag/SeedtagBidderTest.java
Outdated
Show resolved
Hide resolved
5ab22b3 to
74f6a25
Compare
|
@AntoxaAntoxic I did the change you suggested on the unit tests and also fixed the integration test that failed on the CI workflow. Please take a look and let me know if anything else requires my attention. |
|
Hi there @CTMBNara and @osulzhenko ! Any possibility to have a second approval soon? I'm sorry to bother you, we have important clients waiting for our adapter to be released. |
src/test/java/org/prebid/server/bidder/seedtag/SeedtagBidderTest.java
Outdated
Show resolved
Hide resolved
|
@CTMBNara I fixed the linting issue you pointed out on the test, @AntoxaAntoxic I dismissed you review due to the last commit with the commented change. Can you review again? |
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
#3787
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check