Skip to content

Conversation

@osulzhenko
Copy link
Collaborator

@osulzhenko osulzhenko commented May 12, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

For some reason, Spring Boot versions 3.4.3 and 3.4.4 significantly increased application startup time. There don’t appear to be any specific breaking changes, so this is likely caused by dependency updates:
v3.4.3
v3.4.4
However, more concerning part is that runtime for functional tests also increased noticeably.

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko osulzhenko requested review from CTMBNara and Net-burst May 12, 2025 07:31
@osulzhenko osulzhenko self-assigned this May 12, 2025
@osulzhenko osulzhenko added dependencies Pull requests that update a dependency file do not port labels May 12, 2025
@osulzhenko osulzhenko changed the title Change spring-boot version Dependencies: Change spring-boot version May 12, 2025
@CTMBNara CTMBNara merged commit 46cdf39 into master May 19, 2025
8 checks passed
@CTMBNara CTMBNara deleted the downgrade-spring-boot-version branch May 19, 2025 13:28
osulzhenko added a commit that referenced this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file do not port

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants