Skip to content

InvibesBidder: fix parameter parsing issue #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 1 commit into from
May 16, 2025
Merged

InvibesBidder: fix parameter parsing issue #3956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/prebid/server/bidder/invibes/InvibesBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ private static String resolveWidth(Device device) {
}

private static String resolveHost(Integer domainId) {
if (domainId == 0 || domainId == 1 || domainId == 1001) {
if (domainId == null || domainId == 0 || domainId == 1 || domainId == 1001) {
return "bid";
} else if (domainId < 1002) {
return "bid" + domainId;
Expand Down
17 changes: 17 additions & 0 deletions src/test/java/org/prebid/server/bidder/invibes/InvibesBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,23 @@ public void makeHttpRequestsShouldCreateCorrectURLFor1003Zone() {
assertThat(result.getValue().getFirst().getUri()).isEqualTo("https://bid3.videostep.com/bid/");
}

@Test
public void makeHttpRequestsShouldCreateCorrectURLForNullZone() {
// given
final BidRequest bidRequest = givenBidRequest(
identity(),
impBuilder -> impBuilder.banner(Banner.builder().h(BANNER_H).w(BANNER_W).build()),
ExtImpInvibes.of("12", null, InvibesDebug.of("test", true)));

// when
final Result<List<HttpRequest<InvibesBidRequest>>> result = target.makeHttpRequests(bidRequest);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue()).hasSize(1);
assertThat(result.getValue().getFirst().getUri()).isEqualTo("https://bid.videostep.com/bid/");
}

@Test
public void makeHttpRequestsShouldCreateCorrectURLFor0Zone() {
// given
Expand Down
Loading