Test: Invalid GPP string for request handling #3958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osulzhenko
added
tests
…hile-creating-activity-infrastructure' into functional-tests/Invalid-GPP
osulzhenko
changed the base branch from
master
to
handle-exceptions-while-creating-activity-infrastructure
marki1an
requested changes
May 19, 2025
Comment on lines
2049
to
2054
| then: "Generic bidder request should have data in EIDS fields" | ||
| def genericBidderRequest = bidder.getBidderRequest(ampStoredRequest.id) | ||
| assert genericBidderRequest.user.eids[0].source == ampStoredRequest.user.eids[0].source | ||
|
|
||
| and: "Generic bidder request should have data in EIDS fields" | ||
| assert genericBidderRequest.user.eids == ampStoredRequest.user.eids |
Collaborator
There was a problem hiding this comment.
You can leave only last one assert
Collaborator
There was a problem hiding this comment.
Meaning just:
and: "Generic bidder request should have data in EIDS fields"
assert genericBidderRequest.user.eids == ampStoredRequest.user.eids
Collaborator
There was a problem hiding this comment.
And also please check other cases
| def accountId = PBSUtils.randomNumber as String | ||
| def ampStoredRequest = getBidRequestWithPersonalData(accountId) | ||
|
|
||
| and: "amp request with link to account" |
Collaborator
There was a problem hiding this comment.
Suggested change
| and: "amp request with link to account" | |
| and: "Default amp request with link to account" |
| ] | ||
| } | ||
|
|
||
| def "PBS amp call when regs.gpp empty in request should leave EIDS fields in request"() { |
Collaborator
There was a problem hiding this comment.
What about metrics when the transmit activity proceeds?
| assert metrics[ALERT_GENERAL.getValue()] == 1 | ||
|
|
||
| and: "Generic bidder request should have data in UFPD fields" | ||
| def bidderRequest = bidder.getBidderRequest(ampStoredRequest.id) |
Collaborator
There was a problem hiding this comment.
What about bidderRequest.user.eids?
marki1an
approved these changes
May 19, 2025
osulzhenko
merged commit 6c49d73
into
handle-exceptions-while-creating-activity-infrastructure
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check