Skip to content

Conversation

@katherynhrabik
Copy link
Contributor

@katherynhrabik katherynhrabik commented May 20, 2025

🔧 Type of changes

  • new bid adapter
  • [ x ] bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?
Adding ORTB 2.6 support to criteo

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

I added the ortb version, and declared multiformat-supported as true which follows the go version here. but based on this issue, it looks like explicitly flagging that an adapter as gpp-supported may not be necessary?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko
Copy link
Collaborator

@katherynhrabik

Error:  Failures: 
Error:    CriteoTest.openrtb2AuctionShouldRespondWithBidsFromCriteo:30->IntegrationTest.assertJsonEquals:246 ext
Unexpected: errors
 ; seatbid[]: Expected 1 values but got 0 ; 
Unexpected: nbr

@katherynhrabik
Copy link
Contributor Author

@katherynhrabik

Error:  Failures: 
Error:    CriteoTest.openrtb2AuctionShouldRespondWithBidsFromCriteo:30->IntegrationTest.assertJsonEquals:246 ext
Unexpected: errors
 ; seatbid[]: Expected 1 values but got 0 ; 
Unexpected: nbr

I saw it, fixing

@osulzhenko osulzhenko linked an issue May 30, 2025 that may be closed by this pull request
@CTMBNara CTMBNara changed the title declaring ortb 2.6 support for criteo Сriteo: ortb 2.6 support Jun 3, 2025
@CTMBNara CTMBNara merged commit 323bc05 into prebid:master Jun 3, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: Criteo: Declare ORTB 2.6 support

4 participants