Skip to content

Rubicon: Remove default maxbids value #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 1 commit into from
Jul 8, 2025
Merged

Rubicon: Remove default maxbids value #4041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,15 +890,14 @@ private List<String> mapVendorsNamesToUrls(List<Metric> metrics) {
return vendorsUrls.isEmpty() ? null : vendorsUrls;
}

private Integer getMaxBids(ExtRequest extRequest) {
private static Integer getMaxBids(ExtRequest extRequest) {
final ExtRequestPrebid extRequestPrebid = extRequest != null ? extRequest.getPrebid() : null;
final List<ExtRequestPrebidMultiBid> multibids = extRequestPrebid != null
? extRequestPrebid.getMultibid() : null;
final ExtRequestPrebidMultiBid extRequestPrebidMultiBid =
CollectionUtils.isNotEmpty(multibids) ? multibids.getFirst() : null;
final Integer multibidMaxBids = extRequestPrebidMultiBid != null ? extRequestPrebidMultiBid.getMaxBids() : null;

return multibidMaxBids != null ? multibidMaxBids : 1;
return extRequestPrebidMultiBid != null ? extRequestPrebidMultiBid.getMaxBids() : null;
}

private String getGpid(ObjectNode impExt) {
Expand Down
7 changes: 2 additions & 5 deletions src/test/java/org/prebid/server/bidder/rubicon/RubiconBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ public void makeHttpRequestsShouldPassNativeBattrField() {
}

@Test
public void makeHttpRequestsShouldAddMaxbidsAttributeAsOneIfExtPrebidMultibidMaxBidsIsNotPresent() {
public void makeHttpRequestsShouldAddMaxbidsAttributeAsNullIfExtPrebidMultibidMaxBidsIsNotPresent() {
// given
final BidRequest bidRequest = givenBidRequest(
builder -> builder.ext(ExtRequest.of(ExtRequestPrebid.builder()
Expand All @@ -620,7 +620,7 @@ public void makeHttpRequestsShouldAddMaxbidsAttributeAsOneIfExtPrebidMultibidMax
.extracting(Imp::getExt).doesNotContainNull()
.extracting(ext -> mapper.treeToValue(ext, RubiconImpExt.class))
.extracting(RubiconImpExt::getMaxbids)
.containsExactly(1);
.containsOnlyNulls();
}

@Test
Expand Down Expand Up @@ -659,7 +659,6 @@ public void makeHttpRequestsShouldFillImpExt() {
null,
"uuid_bid_id"))
.skadn(givenSkadn)
.maxbids(1)
.build());
}

Expand Down Expand Up @@ -2445,7 +2444,6 @@ public void makeHttpRequestsShouldCreateRequestPerImp() {
.video(Video.builder().build())
.ext(mapper.valueToTree(RubiconImpExt.builder()
.rp(expectedImpExtRp)
.maxbids(1)
.build()))
.build()))
.build();
Expand All @@ -2456,7 +2454,6 @@ public void makeHttpRequestsShouldCreateRequestPerImp() {
.ext(mapper.valueToTree(
RubiconImpExt.builder()
.rp(expectedImpExtRp)
.maxbids(1)
.build()))
.build()))
.build();
Expand Down
1 change: 0 additions & 1 deletion src/test/resources/org/prebid/server/it/openrtb2/magnite/test-magnite-bid-request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"mint_version": ""
}
},
"maxbids": 1,
"tid": "${json-unit.any-string}"
}
}
Expand Down
1 change: 0 additions & 1 deletion src/test/resources/org/prebid/server/it/openrtb2/rubicon/test-rubicon-bid-request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"mint_version": ""
}
},
"maxbids": 1,
"tid": "${json-unit.any-string}"
}
}
Expand Down
Loading