Skip to content

TheTradeDesk throw error for malformed endpoint url #4047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 4 commits into from
Jul 24, 2025
Merged

TheTradeDesk throw error for malformed endpoint url #4047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83f4318
Add ttd/thetradedesk alias
andre-gielow-ttd May 29, 2025
b5aa977
Merge branch 'master' of https://github.com/andre-gielow-ttd/prebid-s…
andre-gielow-ttd Jul 3, 2025
09b5bad
arg-ttd-exception-for-malformed-endpoint
andre-gielow-ttd Jul 3, 2025
3c194cc
Merge branch 'prebid:master' into master
andre-gielow-ttd Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request
}
}

if (StringUtils.isBlank(sourceSupplyId) && StringUtils.isBlank(supplyId)) {
return Result.withError(
BidderError.badInput("Either supplySourceId or a default endpoint must be provided"));
}

final BidRequest outgoingRequest = modifyRequest(request, modifiedImps, publisherId);
final HttpRequest<BidRequest> httpRequest = BidderUtil.defaultRequest(
outgoingRequest,
Expand Down
15 changes: 15 additions & 0 deletions src/test/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,21 @@ public void makeHttpRequestsShouldReturnErrorWhenImpExtCouldNotBeParsed() {
assertThat(result.getValue()).isEmpty();
}

@Test
public void makeHttpRequestsShouldReturnErrorWhenBothSupplySourceIdAndSupplyIdAreNull() {
final TheTradeDeskBidder bidderWithNullSupplyId = new TheTradeDeskBidder(ENDPOINT_URL, jacksonMapper, null);
final BidRequest bidRequest = givenBidRequest(
identity(),
imp -> imp.ext(impExt("publisher", null)));

final Result<List<HttpRequest<BidRequest>>> result = bidderWithNullSupplyId.makeHttpRequests(bidRequest);

assertThat(result.getErrors()).hasSize(1);
assertThat(result.getErrors().getFirst().getMessage())
.isEqualTo("Either supplySourceId or a default endpoint must be provided");
assertThat(result.getValue()).isEmpty();
}

@Test
public void makeHttpRequestsShouldReturnSiteWithExtImpPublisherWhenSiteAndAppArePresent() {
final BidRequest bidRequest = givenBidRequest(
Expand Down
Loading