Skip to content

Conversation

@osulzhenko
Copy link
Collaborator

@osulzhenko osulzhenko commented Sep 4, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko osulzhenko requested a review from marki1an September 4, 2025 09:40
@osulzhenko osulzhenko self-assigned this Sep 4, 2025
@osulzhenko osulzhenko added tests Functional or other tests do not port labels Sep 4, 2025
@osulzhenko osulzhenko changed the title Fix issue with invalid price in tests Fix issue with invalid functional tests Sep 4, 2025
@CTMBNara CTMBNara merged commit fc0fd73 into master Sep 4, 2025
7 of 8 checks passed
@CTMBNara CTMBNara deleted the functional-tests/fix-invalid-price branch September 4, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not port tests Functional or other tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants