imds: Rename to advertising

[pratik-chavan-advertising-dot-com]

Change the adapter code for imds to advertising reflecting the ownership change from iMedia Digital Services to Advertising.com

Other related PRs:
prebid/Prebid.js#12878
prebid/prebid.github.io#5943

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 01cf667

advertising

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/advertising/advertising.go:35:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/advertising/advertising.go:47:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/advertising/advertising.go:60:	makeRequest		88.9%
github.com/prebid/prebid-server/v3/adapters/advertising/advertising.go:134:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/advertising/advertising.go:138:	getExtImpObj		85.7%
github.com/prebid/prebid-server/v3/adapters/advertising/advertising.go:157:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/advertising/advertising.go:195:	getMediaTypeForImp	100.0%
total:										(statements)		94.3%

[bsardo]

Hi @pratik-chavan-advertising-dot-com. This is considered a breaking change since you are removing support for the bidder codes imds and syncormedia. As a result, this would need to be part of a major release, such as v4.0, which will be released later this year, perhaps in a few months.
If you don't want to wait for the next major release, you should introduce bidder code advertising while continuing to offer support for bidder codes imds and syncormedia for backwards compatibility.
One way this could be achieved is to restore imds.yaml and syncormedia.yaml and declare them as hard aliases of advertising via the aliasOf directive.

[pratik-chavan-advertising-dot-com]

Hi @pratik-chavan-advertising-dot-com. This is considered a breaking change since you are removing support for the bidder codes imds and syncormedia. As a result, this would need to be part of a major release, such as v4.0, which will be released later this year, perhaps in a few months. If you don't want to wait for the next major release, you should introduce bidder code advertising while continuing to offer support for bidder codes imds and syncormedia for backwards compatibility. One way this could be achieved is to restore imds.yaml and syncormedia.yaml and declare them as hard aliases of advertising via the aliasOf directive.

@bsardo Thank you so much for the feedback! We would love to get it released sooner for sure. I will make the necessary updates to support backwards compatibility and update the PR soon.

[bretg]

Sorry, we can't let you make changes like this until a major release. Our policy on renames is that you have to retain the old name(s) for a while to allow publishers and host companies a transition period.

Think of this from our point of view -- we've enabled your adapter, and suddenly you've changed the name. We have to stop what we're doing to update our enablement config and every adunit where your old biddercodes were enabled. Reports break. This is not cool.

We would prefer that you leave the old names around for very long time -- years. However, if you want to be uncool, you may do so in the next major release -- PBS 4.0.

For now, simply add 'advertising' as an alias of imds and update your contact info. Note that Microsoft still uses 'appnexus' and Magnite still uses 'rubicon'. Please consider checking out how those companies have done things.

Then you can open a separate PR with the rest of this work, flagging it as 4.0.

[ShriprasadM]

@pratik-chavan-advertising-dot-com , yes. As @bsardo and @bretg mentioned we should wait for major release of prebid-server to avoid impact on existing publishers.
So, in short-term

1. you can introduce new bidder alias.
2. Keep the same maintainer email till major release

[bretg]

Maintainer email can change, your contact info in the Prebid documentation can be updated. You can mention the new brand in your Prebid documentation. All cool.

The issue is that name changes are confusing for many - if an old name simply disappears with no reference, people will ask Prebid "what happened to so-and-so". So please plan a transition period where people can access both old and new names. Thank you.

[bsardo]

@pratik-chavan-advertising-dot-com, I just wanted to check in to see if you had any further questions on the guidance above. Do you have a clear path forward?

[ShriprasadM]

@pratik-chavan-advertising-dot-com : any updates here?

[pratik-chavan-advertising-dot-com]

@ShriprasadM @bsardo My apologies for late response on this! I'll review the suggestions and update the PR soon. Thank you so much for the feedback.

[bsardo]

@pratik-chavan-advertising-dot-com just checking in to see what your plan is going forward given the above comments.

[pratik-chavan-advertising-dot-com]

@bsardo Thank you so much for all the feedback and apologies for the long delay on this. I’ll open a separate PR to implement aliasing while retaining support for the existing bidder codes for backwards compatibility. We can close/decline this PR to keep things clean.

[bsardo]

Sounds good @pratik-chavan-advertising-dot-com