-
Notifications
You must be signed in to change notification settings - Fork 858
New Adapter: iqiyi #4605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
New Adapter: iqiyi #4605
Conversation
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
remove go.mod and go.sum files add go.mod go.sum format json file
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
|
@Heihuang your tests are failing due to formatting issues. Please run |
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
|
I send a request via postman: And I got the response with this error: |
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
pm-nikhil-vaidya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added minor comment, rest looks good
| if response.StatusCode == http.StatusNoContent { | ||
| return nil, nil | ||
| } | ||
|
|
||
| if response.StatusCode != http.StatusOK { | ||
| return nil, []error{&errortypes.BadServerResponse{ | ||
| Message: fmt.Sprintf("Unexpected http status code: %d", response.StatusCode), | ||
| }} | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Use adapters.IsResponseStatusCodeNoContent and adapters.CheckResponseStatusCodeForErrors for checking errors
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
Code coverage summaryNote:
iqiyiRefer here for heat map coverage report |
Adding iqiyi prebid server adapter