New Adapter: ElementalTv #4639
New Adapter: ElementalTv #4639
Conversation
1)Adoppler adapter now has new name ElementalTv 2)Left support adoppler adapter name 3)Update endpoint url 4)Remove clientId param, as it not used anymore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Code coverage summaryNote:
elementaltvRefer here for heat map coverage report |
1) Code refactor rename ElementalTvAdapter to adapter 2) Add OpenRtb version 2.6
Code coverage summaryNote:
elementaltvRefer here for heat map coverage report |
pavel-ptashyts
changed the title
Code coverage summaryNote:
elementaltvRefer here for heat map coverage report |
Code coverage summaryNote:
elementaltvRefer here for heat map coverage report |
# Conflicts: # exchange/adapter_builders.go # openrtb_ext/bidders.go
Code coverage summaryNote:
elementaltvRefer here for heat map coverage report |
Code coverage summaryNote:
elementaltvRefer here for heat map coverage report |
| @@ -0,0 +1,20 @@ | |||
| package elementaltv | |||
There was a problem hiding this comment.
This PR is missing params_test.go, You can refer other adapters for reference.
static/bidder-info/adoppler.yaml
Outdated
| mediaTypes: | ||
| - banner | ||
| - video | ||
| endpoint: "https://pbs.elementaltv.io/ads/processHeaderBid/{{.AdUnit}}" |
There was a problem hiding this comment.
Do we still need adoppler.yaml?
There was a problem hiding this comment.
We want to keep it for backward compatibility, in case someone is currently using our adapter under this name
| @@ -0,0 +1,14 @@ | |||
| endpoint: "https://pbs.elementaltv.io/ads/processHeaderBid/{{.AdUnit}}" | |||
There was a problem hiding this comment.
Please try sample below, as in you example empty body
curl --location 'https://pbs.elementaltv.io/ads/processHeaderBid/SSP:93088015' \ --header 'Content-Type: application/json' \ --header 'Cookie: __cf_bm=0lMezXSzEVUbTG9drwec4EVBXxQsBHbKzjX5S9B8tzY-1768820176-1.0.1.1-jc4VaxbqXsAQLF72OziHFmSV8JGwwfH3imNNHQPb19jZ4tzYJVmTcuZ83BBxJrurRtqW2Zo8ya9_YF6hNEvEUYwZQIzcfYGKky55oVVzT4w' \ --data '{ "id": "6ea9c0b4-d11f-4f57-91c7-3944daf053e3", "imp": [ { "id": "1", "displaymanager":"ELEMENTALTV", "displaymanagerver":"123", "video": { "mimes": [ "video/x-m4v", "video/mp4" ], "protocols": [ 1, 2, 3, 4, 5, 6 ], "w": 1920, "h": 1080, "startdelay": 0, "linearity": 1, "minbitrate": 1, "maxbitrate": 280000, "placement": 1, "ext":{ "custom" : { "iris_context" : ["ic_0755895","ic_4890138"], "iris_id" : "iris_18719437" } } }, "bidfloor": 1, "ssai": 1, "rwdd": 3, "secure": 0, "tagid": 1234 } ], "app": { "id": "APP.ID", "name": "APP.NAME", "bundle": "com.roku.newsy", "domain": "APP.DOMAIN", "ver": "APP.VER", "cat": [ "IAB1-1", "IAB1-2" ], "storeurl":"APP.STORE.URL", "ext": { "inventorypartnerdomain": ["INV.PARTNER.DOMAIN","INV.PARTNER.DOMAIN2"] }, "publisher": { "name": "PUB.NAME", "domain": "PUB.DOMAIN" }, "content": { "id": "123", "ext": { "channel": "ESPN", "network": "NETWORK" }, "episode": 25, "title": "TITLE", "series": "SERIES", "season": "SEASON", "artist": "ARTIST", "genre": "GENRE", "contentrating":"MPAA", "userrating":"likes", "len":"500", "url": "https://content.url", "cat": [ "IAB1-1" ], "producer": { "id": "111", "name": "PROD.NAME", "domain": "PROD.DOMAIN", "cat": [ "IAB1-1", "IAB1-2" ] }, "prodq": 1, "context": 1, "qagmediarating": 3, "keywords": "CONTENT.KEYWORDS", "livestream": 1, "language":"en" } }, "device": { "ua": "BroadSign Reach DOOH Player/1.0", "geo": { "type": 2, "metro": "508", "city": "Beaver", "ipservice": 3 }, "dnt": 0, "lmt": 0, "ip": "128.122.11.223", "ifa": "4CE8BBA6-FB02-476A-8867-6F8EDB06389D", "ext": { "ifa_type": "rida" } }, "user": { "id": "ba02311e9a-421a-4758-93e7-22222", "ext": { "consent": "consent", "eids": [ { "source": "smartadserver.com", "uids": [ { "id": "AqPi24JAb35cojtSgXPo7HONQaP9P1AGsCOARMLdKcUsjXJr1Q5OFvuH" } ] }] } }, "regs": { "coppa": "1", "ext": { "gdpr": 1, "us_privacy": "1YNN" } }, "at": 1, "tmax": 2000, "bcat": [ "IAB26" ], "source": { "fd": 0, "schain": { "nodes": [ { "asi": "external.com", "sid": "2637", "rid": "80831756180820447436e1", "hp": 1 } ], "ver": "1.0", "complete": 1 }, "pchain": "" }, "ext": { "wt": 1, "clktrkrq": 0, "media_src": "admixer", "ssp": "admixer", "is_secure": 1, "tgroup": [ 3319 ] } }'
| @@ -0,0 +1,14 @@ | |||
| endpoint: "https://pbs.elementaltv.io/ads/processHeaderBid/{{.AdUnit}}" | |||
| maintainer: | |||
| email: support@elementaltv.com | |||
There was a problem hiding this comment.
Email sent to this email address, Kindly respond for verification.
add params_test.go
add params_test.go
Code coverage summaryNote:
elementaltvRefer here for heat map coverage report |
pavel-ptashyts
changed the title
pavel-ptashyts
changed the title
Remove adoppler.yaml
Code coverage summaryNote:
elementaltvRefer here for heat map coverage report |
3 participants
1)Adoppler adapter now has new name ElementalTv
2)Left support adoppler adapter name
3)Update endpoint url
4)Remove clientId param, as it not used anymore