Skip to content

Conversation

@bretg
Copy link
Contributor

@bretg bretg commented Mar 13, 2025

We've been getting support issues where people are using floorsMin as a way to set static floors. This doesn't work.

@netlify
Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit b3bb03c
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67d314bd6a16e900086c8df1
😎 Deploy Preview https://deploy-preview-5946--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bretg bretg merged commit bc79e8c into master Mar 13, 2025
2 checks passed
@bretg bretg deleted the floors-update branch March 13, 2025 17:24
@muuki88
Copy link
Contributor

muuki88 commented Mar 18, 2025

Thanks @bretg

We have been doing this for years now:

{
    floors: {
      currency: 'usd',
      schema: {
        delimiter: '|',
        fields: ['mediaType']
      },
      values: {
        '*': priceRule.floorprice
      }
    }
}

While this works, the ortb2Imp setting is a lot cleaner. Does the pbjs floors module pick it up there as well? From the code ( https://github.com/prebid/Prebid.js/blob/master/modules/priceFloors.js ) it looks like it wouldn't have the desired effect.

@bretg
Copy link
Contributor Author

bretg commented Mar 24, 2025

Does the pbjs floors module pick it up there as well?

Hmm. I see - I wasn't thinking about a "static signal+enforce" mode. The ortb2Imp approach only works for signaling.

We'll have to update the doc to note that and your approach if they want enforcement as well as signaling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants