-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New adapter: Adpixis #5965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
New adapter: Adpixis #5965
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
dfbb830
new adapter adpixis.md
46aeb7c
pbjs support
deb2d81
pbjs support false
66be4ec
add empty line
7652932
Update adpixis.md
quietPusher dcbfca9
Update adpixis.md
quietPusher 8d4bd40
Update adpixis.md
quietPusher 2be848a
Update adpixis.md
apykhteyev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| --- | ||
| layout: bidder | ||
| title: AdPixis | ||
| description: Prebid AdPixis Bidder Adaptor | ||
| biddercode: adpixis | ||
| pbjs: false | ||
| pbs: true | ||
| media_types: video, banner | ||
| userIds: all | ||
| fpd_supported: false | ||
| tcfeu_supported: false | ||
| usp_supported: true | ||
| coppa_supported: true | ||
| schain_supported: true | ||
| prebid_member: false | ||
| ortb_blocking_supported: true | ||
| multiformat_supported: will-bid-on-one | ||
| floors_supported: false | ||
| aliasCode: limelightDigital | ||
| sidebarType: 1 | ||
| --- | ||
|
|
||
| ### Bid Params | ||
|
|
||
| {: .table .table-bordered .table-striped } | ||
|
|
||
| | Name | Scope | Description | Example | Type | | ||
| |:--------------|:---------|:--------------------------------------------------------------|:-----------------------|:----------| | ||
| | `host` | required | Ad network's RTB host | `'<adserving domain>'` | `string` | | ||
| | `adUnitId` | required | Ad Unit Id will be generated on <Public title name> Platform. | `42` | `integer` | | ||
| | `adUnitType` | required | Type of Ad Unit (`'video'`, `'banner'`) | `'banner'` | `string` | | ||
| | `publisherId` | required | Publisher ID | `'12345'` | `string` | | ||
| | `custom1` | optional | Custom targeting field 1 | `'custom1'` | `string` | | ||
| | `custom2` | optional | Custom targeting field 2 | `'custom2'` | `string` | | ||
| | `custom3` | optional | Custom targeting field 3 | `'custom3'` | `string` | | ||
| | `custom4` | optional | Custom targeting field 4 | `'custom4'` | `string` | | ||
| | `custom5` | optional | Custom targeting field 5 | `'custom5'` | `string` | | ||
|
|
||
| <Public title name> server-side Prebid Server adapter requires only `publisherId` and `host` parameters. But <Public title name> client-side Prebid.js adapter requires only `host`, `adUnitId`, `adUnitType`. | ||
bretg marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| <Public title name> server-side Prebid Server adapter supports only `banner`, `video`, `audio`, `native` media types. But <Public title name> client-side Prebid.js adapter supports only `banner` and `video` media types, doesn't support `audio` and `native`. | ||
bretg marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, host cannot be a required parameter. See https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#consider-your-geography
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment below suggests that 'host' is only needed for Prebid.js, but the metadata field says
pbjs: false. Something's off.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bretg thanks for your comments, we will fix everything, about the
host- we use it only as query parameter for PBS to identify the publisher on our sidehttps://github.com/prebid/prebid-server/blob/master/static/bidder-info/limelightDigital.yaml#L1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bretg @apykhteyev Fixed
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, 'host' isn't fixed. PBS does not allow any kind of domain (e.g. adpixis-rtb.com) as a required parameter. It's ok to be an optional parameter, so the adapter has to have a reasonable default.
The way to think about this is from the publisher's perspective:
The way you need to do that is to just hardcode the alias domain in your YAML file. e.g.
"http://ads-pbs.ortb.net/openrtb/{{.PublisherID}}?host=adpixis-rtb.com"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. I've set Host to optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apykhteyev can you please address these questions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The limelight digital adapter, which adpixis is an alias of, still has
hostas required despite the documentation change here to optional.Host does not correspond to the bidder domain, though I imagine it is being used to route requests internally somehow. Is that the case @apykhteyev? If that is true, @bretg does this really have to be optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The important thing is that we do not force publishers decide how to route each request. I agree the 'host' parameter is misnamed if it's just something like an account ID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bretg @bsardo we did
hostparameter optional as you requested for this adapter. Even I can remove it from here it all, but I can't make it optional for our limelight digital adapter.Let me try to explain our business.
We offer our RTB solution as SaaS for multiple clients and they use our infrastructure. Most of our clients request whitelabel domain and whitelabel pbs adapter. So it's ok we can create this alias and we don't require this
hostparameter and it's enough to have justpublisherIdBut some of clients don't need whitelabel solution and use our default domain
ortb.net. So internally we use their client dedicated subdomain to differentiate request from different clients. Different clients could have same publisher ids, that why justpublisherIdis not enough for main limelightDigital adapter. As PBS don't allow to use dynamic subdomain - we moved this host to query parameters, and use it internally to understand what's client send us request from regular limelightAdapter. Our main adapter don't usehostfor any rerouting and just pass it as is for backend processingAnd as I said we remove
hostfrom whitelabeled version. Hope it clarifies. Let me know for any questions