Merged
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bretg
previously requested changes
Mar 31, 2025
dev-docs/bidders/performist.md
Outdated
|
|
||
| | Name | Scope | Description | Example | Type | | ||
| |:--------------|:---------|:--------------------------------------------------------------|:-----------------------|:----------| | ||
| | `host` | required | Ad network's RTB host | `'<adserving domain>'` | `string` | |
Contributor
There was a problem hiding this comment.
host cannot be required for PBS. The text below suggests that this only needed for PBJS, but that conflicts with the declaration above pbjs:false
dev-docs/bidders/performist.md
Outdated
| | `custom4` | optional | Custom targeting field 4 | `'custom4'` | `string` | | ||
| | `custom5` | optional | Custom targeting field 5 | `'custom5'` | `string` | | ||
|
|
||
| <Public title name> server-side Prebid Server adapter requires only `publisherId` and `host` parameters. But <Public title name> client-side Prebid.js adapter requires only `host`, `adUnitId`, `adUnitType`. |
Contributor
There was a problem hiding this comment.
Yo - project limelight. Heads up. Please update your documentation template to have the submitters be more careful.
This is the 3rd almost identical piece of documentation with the same problems. We would appreciate better attention to detail here. Please fix the "" think on this line and the next.
Contributor
Author
There was a problem hiding this comment.
Hello @bretg. Done, I'll do better next time :-)
Modify required fields
fix host
Host to Optional
muuki88
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
📋 Checklist