Skip to content

Conversation

@sebrobert
Copy link
Contributor

Add mention of User Sync and missing features

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

@netlify
Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 360c778
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67f901f89979540008de823b
😎 Deploy Preview https://deploy-preview-5972--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bretg
Copy link
Contributor

bretg commented Apr 2, 2025

This looks related to prebid/Prebid.js#12944.

Couple of questions/requests:

  1. please consider adding the many fields missing from your adapter's header as described in https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter

e.g.

dsa_supported: true/false
usp_supported: true/false
coppa_supported: true/false
gpp_sids: tcfeu, tcfca, usnat, usstate_all, usp
schain_supported: true/false
dchain_supported: true/false
userId: (list of supported vendors)
media_types: banner, video, native
safeframes_ok: true/false
deals_supported: true/false
floors_supported: true/false
fpd_supported: true/false
pbjs: true/false
pbs: true/false
prebid_member: true/false
multiformat_supported: will-bid-on-any, will-bid-on-one, will-not-bid
ortb_blocking_supported: true/partial/false
privacy_sandbox: no or comma separated list of `paapi`, `topics`
  1. Your 'currency' parameter is quite unfriendly to publishers. They declare their auction currency using the currency module. You module should look at that and decide which currency to bid in.

@bretg bretg self-requested a review April 2, 2025 20:33
@bretg bretg added the question label Apr 2, 2025
@bretg
Copy link
Contributor

bretg commented Apr 10, 2025

^^ @sebrobert

@sebrobert
Copy link
Contributor Author

sebrobert commented Apr 11, 2025

Thanks for the mention @bretg , I will have a look ASAP to your comments

@sebrobert
Copy link
Contributor Author

Hi again @bretg, I have added the missing fields, and open a todo in our tech team to work on all the currently "unsupported" options for future update on our BidAdapter, so all clear on that side for that doc update ✅

Concerning the currency one → we just let the publisher to select what is its preferred one, knowing that we are making the conversion on our end for the publisher.

  • If he requires USD, and our bid is in EUR, then we are converting the value in USD with our own system.

By having a look on the Prebid.js Currency Module spec, the system seems to be complex to be configured by publishers, do you have adoption stats on that module that shows the %age of active usage ? According to that, we will do new devs on our adapter to be able to rely on your Currency Module, but I don't think that our currency param is unfriendly as we are trying to solve complexity of exchange rates natively in our code.

Thanks for your time !

@bretg
Copy link
Contributor

bretg commented Apr 11, 2025

By having a look on the Prebid.js Currency Module spec, the system seems to be complex to be configured by publishers, do you have adoption stats on that module that shows the %age of active usage ?

The currency module is one of the most popular modules in Prebid.js. Prebid's currency conversion file is literally the most frequently downloaded file on the huge jsdelivr CDN. Apparently people figure it out.

Prebid publishers have told us unequivocally that they don't like having to pass the same things to different bidders on different locations. We've been through this with pos, floors, first party data, and others. What I'm asking you for is this:

  1. You module needs to check whether the publisher has the currency in the standard way. If so, use that.
  2. If they haven't set it the standard way, then you can check your bidder-specific parameter.

@bretg
Copy link
Contributor

bretg commented Apr 16, 2025

So I went over to the actual adapter code and it's doing things fine:

publisherCurrency = getCurrencyFromBidderRequest(bidderRequest) || getValue(bid.params, 'currency') || 'EUR';

This is perfect.

@bretg
Copy link
Contributor

bretg commented Apr 16, 2025

The code is merged and on-deck to be released with PBJS 9.40. This docs PR can be merged after that.

@bretg bretg merged commit 20f9e0b into prebid:master Apr 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants