-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update BeOp doc to add User Syncs reference #5972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This looks related to prebid/Prebid.js#12944. Couple of questions/requests:
e.g.
|
|
^^ @sebrobert |
|
Thanks for the mention @bretg , I will have a look ASAP to your comments |
|
Hi again @bretg, I have added the missing fields, and open a todo in our tech team to work on all the currently "unsupported" options for future update on our BidAdapter, so all clear on that side for that doc update ✅ Concerning the currency one → we just let the publisher to select what is its preferred one, knowing that we are making the conversion on our end for the publisher.
By having a look on the Prebid.js Currency Module spec, the system seems to be complex to be configured by publishers, do you have adoption stats on that module that shows the %age of active usage ? According to that, we will do new devs on our adapter to be able to rely on your Currency Module, but I don't think that our Thanks for your time ! |
de84a74 to
360c778
Compare
The currency module is one of the most popular modules in Prebid.js. Prebid's currency conversion file is literally the most frequently downloaded file on the huge jsdelivr CDN. Apparently people figure it out. Prebid publishers have told us unequivocally that they don't like having to pass the same things to different bidders on different locations. We've been through this with pos, floors, first party data, and others. What I'm asking you for is this:
|
|
So I went over to the actual adapter code and it's doing things fine: This is perfect. |
|
The code is merged and on-deck to be released with PBJS 9.40. This docs PR can be merged after that. |
Add mention of User Sync and missing features
🏷 Type of documentation
📋 Checklist