Prebid Mobile: 3.0 updates #5982
Conversation
|
|
||
| {% endcapture %} | ||
| {% capture gma11 %}Prebid.initializeSDK(gadMobileAdsVersion: GADGetStringFromVersionNumber(GADMobileAds.sharedInstance().versionNumber) { status, error in | ||
| {% capture gma11 %} |
There was a problem hiding this comment.
The spaces were omitted intentionally to avoid rendering issues.
There was a problem hiding this comment.
It looks like a conflict here. The linter requires the addition of a line before and after the code block. I'll take a look at how to fix it
There was a problem hiding this comment.
I suppose removing code block syntax may help
mdanylov-sigma
force-pushed
the
mobile/code-integration-3.0-updates
branch
from
0b2113f to
fad2a05
Compare
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Thanks for the draft! My major concern is that this document is too aggressive in eliminating instructions that are still relevant for users of SDK 2.5. I don't think you can assume people are going to upgrade to 3.0 for at least 6 months. In the meantime, they still need docs for 2.5. So instead of deleting everything that's 2.5 only, I think you need to flag it somehow. Maybe just a parenthesis like "(2.x only)" or maybe an alert.
My next biggest concern is it looks like the account-settings has been misnamed or misunderstood. Account settings is the GLOBAL ext.prebid.storedrequest. It is NOT imp.ext.prebid.storerequest... that's the AdUnit-level settings.
prebid-mobile/recipes/subrecipes/android/gam-bidding-only-html-banner.md
Show resolved
Hide resolved
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Getting there! Made a few wordsmithing updates and pointed a few migration functions/settings that seem to be missing. An important role of the "API changes" docs is to help app developers figure out how to move from 2.x to 3.0, so guidance with stuff like isCoppaEnabled would be very helpful.
| - App and User first party data should use the [functions defined for those purposes](/prebid-mobile/pbm-api/ios/pbm-targeting-ios.html#first-party-data) | ||
| - See the [Prebid Server auction endpoint](/prebid-server/endpoints/openrtb2/pbs-endpoint-auction.html#prebid-server-ortb2-extension-summary) reference for more information about how it will process incoming fields. | ||
|
|
||
| ### Deprecated |
There was a problem hiding this comment.
Android and iOS docs differ; is it expected? Check out pbm-targeting-ios.md
|
|
||
| - Display Banner via `BannerAdUnit` | ||
| - Video Banner and Instream Video via `VideoAdUnit` | ||
| - Video Banner and Instream Video via `InStreamVideoAdUnit` |
There was a problem hiding this comment.
Android and iOS docs differ; is it expected? Check out ios-sdk-integration-pb.md
🏷 Type of documentation
📋 Checklist