Skip to content

fix: pbAdSlot example showing pbjs.addAdUnits as variadic#6216

Merged
muuki88 merged 1 commit intoprebid:masterfrom
lyricwulf:fix-add-ad-units-not-variadic
Aug 19, 2025
Merged

fix: pbAdSlot example showing pbjs.addAdUnits as variadic#6216
muuki88 merged 1 commit intoprebid:masterfrom
lyricwulf:fix-add-ad-units-not-variadic

Conversation

@lyricwulf
Copy link
Contributor

I was following along the documentation for pbAdSlot, found the example code was showing pbjs.addAdUnits(unit1, unit2) but the function is not variadic. Only takes one argument of AdUnit | Array.

I also checked the rest of the docs for any other instance of this, however this is the only case I found :)

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

@netlify
Copy link

netlify bot commented Aug 18, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit d5715ed
🔍 Latest deploy log https://app.netlify.com/projects/prebid-docs-preview/deploys/68a3b7a782e2cb000838da18
😎 Deploy Preview https://deploy-preview-6216--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the docs better 👍

@muuki88 muuki88 merged commit d1ee487 into prebid:master Aug 19, 2025
6 checks passed
@lyricwulf lyricwulf deleted the fix-add-ad-units-not-variadic branch August 21, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants