Skip to content

Fix download page not removing modules it says it's removing #6340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muuki88 merged 1 commit into from
Nov 14, 2025
Merged

Fix download page not removing modules it says it's removing #6340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions assets/js/download.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@
$('#download-button').html('<i class="glyphicon glyphicon-send"></i> Sending Request...').addClass('disabled');

var form_data = get_form_data();
const removedModules = form_data.removedModules;
delete form_data.removedModules;
$.ajax({
type: "POST",
url: "https://js-download.prebid.org/download",
Expand All @@ -112,12 +114,12 @@
triggerDownload(jsBlob, filename);
triggerDownload(new Blob([configData], { type: "application/json" }), "prebid-config.json");

if (form_data["removedModules"].length > 0) {
if (removedModules.length > 0) {
alert(
"The following modules were removed from your download because they aren't present in Prebid.js version " +
form_data["version"] +
": " +
JSON.stringify(form_data["removedModules"])
JSON.stringify(removedModules)
);
}
})
Expand Down Expand Up @@ -179,7 +181,7 @@
});

return {
modules: renameModules(version, modules),
modules: renameModules(version, modules).filter(mod => !removedModules.includes(mod)),
version,
removedModules,
};
Expand Down