Skip to content

Breaking: run npm install in guest #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vweevers wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Breaking: run npm install in guest #24

vweevers wants to merge 1 commit into from

Conversation

@vweevers
Copy link
Member

@vweevers vweevers commented Nov 13, 2025

Avoiding a repeated install reduced build time but it breaks use of node-addon-api: #23

This is a breaking change because it removes the --modules option from #19 which is no longer necessary (cc @kirrg001).

@vweevers
Breaking: run npm install in guest
40eca0c 
Avoiding a repeated install reduced build time but it breaks use of
node-addon-api: #23

This is a breaking change because it removes the `--modules` option
from #19 which is
no longer necessary.

Category: change
@vweevers vweevers added the semver-major Changes that break backward compatibility label Nov 13, 2025
@vweevers vweevers mentioned this pull request Nov 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

semver-major Changes that break backward compatibility

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vweevers