Skip to content

Conversation

@Fujikawas
Copy link
Member

@Fujikawas Fujikawas commented Oct 17, 2025

Description

To close #56.
Different initialization option for checkpointing is provided to match the need of different cases in examples/ and the heat-conduction case .

Checklist

  • I made sure that the source files are formatted properly.
  • I added my changes to the changelog (CHANGELOG.md)
  • I updated the documentation.
  • I added a test for the new feature.

@Fujikawas Fujikawas requested a review from fsimonis October 17, 2025 11:33
@Fujikawas Fujikawas requested a review from IshaanDesai October 20, 2025 10:39
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this important contribution. I have a few comments (more like questions for my own understanding). I would recommend moving the test from the examples/ folder to a separate test/ folder.

@IshaanDesai IshaanDesai added the enhancement New feature or request label Oct 20, 2025
@Fujikawas
Copy link
Member Author

Fujikawas commented Oct 20, 2025

I agree that examples/ folder is not a place for the test. I suggest doing a refactor/renaming after #52, since then we can have proper test/ folder for testing the adapter features.

In my opinion, #52 is independent of creating a test/ folder right now. Are you using the folder hierarchy in examples/ in the build process of the test? If yes, that would be a valid reason to put the test there. We can move the test after finalizing this PR too.

@Fujikawas
Copy link
Member Author

In my opinion, #52 is independent of creating a test/ folder right now. Are you using the folder hierarchy in examples/ in the build process of the test? If yes, that would be a valid reason to put the test there. We can move the test after finalizing this PR too.

The current test/ folder contains scripts to run the examples and is not for tests. Let's do a refactor of the folder structure later.

@IshaanDesai
Copy link
Member

The two-scale heat conduction tutorial case with changes from precice/tutorials#676 fails with the changes from this branch. The Newton solver on the macro scale reaches the default maximum permissible iterations (10). This hints at potential issues related to checkpointing the time variables.

Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

precice/tutorials#676 (comment) shows that the changes here work as expected.

Copy link
Collaborator

@mathiskelm mathiskelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, otherwise good. Should check again with the tutorials branch.

@Fujikawas Fujikawas merged commit 77e0fe5 into develop Oct 23, 2025
6 checks passed
@Fujikawas Fujikawas deleted the checkpointing branch October 23, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add functionality to handle checkpointing

5 participants