-
-
Notifications
You must be signed in to change notification settings - Fork 4
Add dumux-customised checkpointing feature #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
IshaanDesai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this important contribution. I have a few comments (more like questions for my own understanding). I would recommend moving the test from the examples/ folder to a separate test/ folder.
In my opinion, #52 is independent of creating a |
The current |
|
The two-scale heat conduction tutorial case with changes from precice/tutorials#676 fails with the changes from this branch. The Newton solver on the macro scale reaches the default maximum permissible iterations (10). This hints at potential issues related to checkpointing the time variables. |
IshaanDesai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
precice/tutorials#676 (comment) shows that the changes here work as expected.
mathiskelm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, otherwise good. Should check again with the tutorials branch.
Description
To close #56.
Different initialization option for checkpointing is provided to match the need of different cases in
examples/and the heat-conduction case .Checklist
CHANGELOG.md)