Skip to content

Add support for 3D coupling #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NiklasVin merged 35 commits into from
Oct 1, 2025
Merged

Add support for 3D coupling #51

NiklasVin merged 35 commits into from
Oct 1, 2025

Conversation

@NiklasVin
Copy link
Collaborator

@NiklasVin NiklasVin commented Sep 5, 2025 •
edited
Loading

Main changes of this PR

Add 3d support via just-in-time mapping

Motivation and additional information

Closes #36 and is an alternative suggestion to support 3D cases to #26.

Author's checklist

  • I updated the changelog file CHANGELOG.md if there are user-observable changes since the last release.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

NiklasVin and others added 29 commits April 28, 2025 10:15
@NiklasVin
first version of 3d coupling; errors are rather large :(
7c01e93
@NiklasVin
Tmp
68e8205
@NiklasVin
Tmp2
6927e93
@NiklasVin
Small tutorial for jit-mapping
4369ddd
@NiklasVin
Dont know whats wrong
e0049ec
@NiklasVin
Debug2
59e60da
@NiklasVin
Debug3
750abb4
@NiklasVin
Partitioned heat conduction with jit-mapping
fc52b64
@NiklasVin
Enable jit-mapping for Neumann side
c336ecf
@NiklasVin
Merge pull request #1 from NiklasVin/jit-mapping-debugging
cfa8166 
Jit mapping debugging
@NiklasVin
Clean up fenicsxprecice.py and add write_data_at_coordinates
e1607b3
@NiklasVin
revert changes in coupling_mesh.py and expression_core.py
1ca9c3b
@NiklasVin
Clean code, add comments and documentation, and fix bug in fenicsxpre…
97f4a7e 
…cice
@NiklasVin
Formatting and changelog entry
462e296
@NiklasVin
add assertion
cef32e2
@NiklasVin
make comment clearer
7579096
@NiklasVin
Merge from develop
62080e2
@NiklasVin
revert changes in fenicsxprecice library for 3d coupling. Using jit-m…
0125fd8 
…apping makes more sense
@NiklasVin
Merge branch 'jit-mapping' into 3d-coupling
44b1bd4
@NiklasVin
Fixed bug in coupling boundary definition. Now it is working with jit…
2564697 
… mapping
@NiklasVin
Complex geometry for heat equation. Something not working with Neuman…
55e9df7 
…n boundaries
@NiklasVin
Complex 3d coupling case done. Error is still rather large...
c3d977a
@NiklasVin
Replace outdated flux computation
57b7b46
@NiklasVin
Fix memory pollution from determine_gradient. Fix vector mapping for …
6c2f734 
…Neumann boundaries
@NiklasVin
3d heat equation works now
12dbade
@NiklasVin
Add changelog entry
5868603
@NiklasVin
Merge branch 'develop' into 3d-coupling
fd1fae9
@NiklasVin
revert changes in expression core
b94c8f1
@NiklasVin
Merge branch '3d-coupling' of github.com:NiklasVin/fenicsx-adapter in…
77bd8fe 
…to 3d-coupling
@IshaanDesai IshaanDesai added the enhancement New feature or request label Sep 8, 2025
@NiklasVin NiklasVin marked this pull request as ready for review September 10, 2025 08:36
IshaanDesai
IshaanDesai requested changes Sep 16, 2025
View reviewed changes
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this important contribution! Please see my comments.

@NiklasVin NiklasVin merged commit fa97ffa into precice:develop Oct 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IshaanDesai IshaanDesai IshaanDesai approved these changes

Assignees

@NiklasVin NiklasVin

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

support for 3d models

2 participants

@NiklasVin @IshaanDesai