Contribution to Issue #66: Int based implementation#67
Merged
IshaanDesai merged 8 commits intoprecice:developfrom Feb 24, 2026
Merged
Contribution to Issue #66: Int based implementation#67IshaanDesai merged 8 commits intoprecice:developfrom
IshaanDesai merged 8 commits intoprecice:developfrom
Conversation
IshaanDesai
approved these changes
Feb 24, 2026
Member
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
Looks good. The tutorial also runs as expected 👍
Member
|
The CI fails due to redundant checks in the tutorial case, which will be fixed in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Implemented int based unique coordinates version.
Splits float values into reasonable sizes (10 digits) and coverts those to int64 (~16 Digits).
Unique operation on int values does not need rounding anymore.
Motivation and additional information
Resolves Issue #66
Author's checklist
CHANGELOG.mdif there are user-observable changes since the last release.Reviewers' checklist