Skip to content

Conversation

@MakisH
Copy link
Member

@MakisH MakisH commented Mar 18, 2025

This adds a workflow to run the system tests with the latest state of each involved component. The workflow is triggered every night at 4am, or manually.

I add this here and not in the preCICE repository, as this repository is the consumer of all and defines the related infrastructure. We still need some way to notify the maintainers in case of failure (this is a bit complicated, let's do it in a separate PR).

While we already have a fully-customizable, manual workflow, this allows to just click a button and test the latest state of everything. As such, we can say it closes #552.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@MakisH MakisH self-assigned this Mar 18, 2025
@MakisH MakisH marked this pull request as ready for review March 18, 2025 13:55
@MakisH
Copy link
Member Author

MakisH commented Mar 18, 2025

@BenjaminRodenberg does this make sense to you? I have not yet tested it (because it would only work on the default branch), but it is largely copied from https://github.com/precice/precice/blob/develop/.github/workflows/system-tests.yaml

Do you think the names are reasonable?

Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MakisH MakisH merged commit a39364f into develop Mar 18, 2025
1 check passed
@MakisH MakisH deleted the nightly-tests branch March 18, 2025 15:36
jobs:
gather-refs:
name: Map Git branches to latest refs
if: ${{ github.event.label.name == 'trigger-system-tests' }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed these if conditions in 3bb4ab5, as the jobs were skipped. These indeed don't make sense in this context.

@MakisH
Copy link
Member Author

MakisH commented Mar 18, 2025

Triggered a manual job: https://github.com/precice/tutorials/actions/runs/13927405810

Let's see tomorrow if the scheduling also worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Specify default build arguments

2 participants