Remove simulation time from precice-config file of two-scale heat conduction #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakisH
approved these changes
Sep 17, 2025
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
The visualization of the config also needs to be updated: https://precice.org/tutorials-two-scale-heat-conduction.html#configuration
MakisH
reviewed
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to precice/micro-manager#188, the Micro Manager no longer outputs diagnostics data of the micro simulation
solve()CPU time. The corresponding data needs to be removed from theprecice-config.xmlof the two-scale heat conduction.This PR is essentially a cleanup of a data that should have been removed a long time ago.
Checklist:
changelog-entries/<PRnumber>.md.