Add and comply with Bugbear checks

Author: Epse

pyproject.toml

@@ -59,5 +59,5 @@ strict = true
 include = ["src/obelisk/**/*.py"]
 
 [tool.ruff.lint]
-select = ["E4", "E7", "E9", "F", "ASYNC", "S"]
+select = ["E4", "E7", "E9", "F", "ASYNC", "S", "B"]
 ignore = []

src/obelisk/asynchronous/base.py

@@ -35,7 +35,7 @@ def __init__(
         self,
         client: str,
         secret: str,
-        retry_strategy: RetryStrategy = NoRetryStrategy(),
+        retry_strategy: RetryStrategy = NoRetryStrategy(),  # noqa: B008   # This is fine to bew shared
         kind: ObeliskKind = ObeliskKind.CLASSIC,
     ) -> None:
         self._client = client

src/obelisk/asynchronous/client.py

@@ -103,11 +103,11 @@ async def fetch_single_chunk(
         except json.JSONDecodeError as e:
             msg = f"Obelisk response is not a JSON object: {e}"
             self.log.warning(msg)
-            raise ObeliskError(msg)
+            raise ObeliskError(msg) from e
         except ValidationError as e:
             msg = f"Response cannot be validated: {e}"
             self.log.warning(msg)
-            raise ObeliskError(msg)
+            raise ObeliskError(msg) from e
 
     async def query(
         self,

src/obelisk/asynchronous/core.py

@@ -222,7 +222,7 @@ def __init__(
         self,
         client: str,
         secret: str,
-        retry_strategy: RetryStrategy = NoRetryStrategy(),
+        retry_strategy: RetryStrategy = NoRetryStrategy(),  # noqa: B008   # This is fine to bew shared
     ) -> None:
         BaseClient.__init__(
             self,
@@ -281,11 +281,11 @@ async def fetch_single_chunk(self, params: QueryParams) -> QueryResult:
         except json.JSONDecodeError as e:
             msg = f"Obelisk response is not a JSON object: {e}"
             self.log.warning(msg)
-            raise ObeliskError(msg)
+            raise ObeliskError(msg) from e
         except ValidationError as e:
             msg = f"Response cannot be validated: {e}"
             self.log.warning(msg)
-            raise ObeliskError(msg)
+            raise ObeliskError(msg) from e
 
     async def query(self, params: QueryParams) -> List[Datapoint]:
         params.cursor = None

src/obelisk/sync/client.py

@@ -36,7 +36,7 @@ def __init__(
         self,
         client: str,
         secret: str,
-        retry_strategy: RetryStrategy = NoRetryStrategy(),
+        retry_strategy: RetryStrategy = NoRetryStrategy(),  # noqa: B008   # This is fine to bew shared
         kind: ObeliskKind = ObeliskKind.CLASSIC,
     ):
         self.async_obelisk = AsyncObelisk(client, secret, retry_strategy, kind)

src/obelisk/types/core.py

@@ -27,7 +27,7 @@
 """
 
 
-class Constraint(ABC):
+class Constraint(ABC):  # noqa: B024 # This is just a marker class
     """
     Constraints are simply groups of :class:`Comparison`,
     such as :class:`And`, or :class:`Or`.