refactor(upload): replace module with rattler_upload crate
#4245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
added
refactor
lucascolley
changed the title
rattler_upload craterattler_upload crate
magentaqin
force-pushed
the
refactor/upload-alignment
branch
from
296ff1e to
9e386b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes I made
Replace upload module with
rattler_uploadcrate, and passauth_storetorattler_upload. Related PR: conda/rattler#1575Things Left
Originally, upload module in
rattler_builddoesn't support upload URL, and sincerattler_uploadcrate is migrated fromrattler_build, it lacks support upload URL(which is the upload function inpixi).Next step, I need to migrate "upload URL" part in
pixitorattler_upload, and let upload function 100% aligns betweenrattler_buildandpixi.But in
pixi, "upload URL" depends onreqwest_client_builder. If we migrate the whole part torattler_upload, it will makerattlerdepends onpixi, which becomes a circular dependency.