fix: concurrent pixi install #4566
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
added
bug
nichmor
reviewed
Oct 22, 2025
| // 1. We have the exclusive write lock, so no one else is installing | ||
| // 2. If a previous process crashed, the state might be stale | ||
| // 3. The begin() method is idempotent if already in "Installing" state | ||
| write_guard.begin().await.map_err(|e| { |
There was a problem hiding this comment.
Do you think it makes sense to check for is_ready state, and if it was already installed early out?
We are doing the same in create_exec_prefix, so I'm thinking maybe we can apply this pattern here?
|
Small question - apart from using that pre-commit configuration, is there a way to test it on some examples? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1482. Let me know if there's anything I need to do!