feat: support for Fish on Windows #4775
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4648.
Currently, on Windows (via #3981) we launch bash by creating a new bash process with
--init-filewhich contains all the environment variables, completions and custom prompt.This doesn't work for other shells unfortunately since
--init-fileis bash-specific. This PR splits the init file into two parts: one for the environment variables (calledinit_filein code), which uses bash syntax, and the other one for completions and custom prompt, which is specific to the shell that's starting (calledenv_filein code).pixi shelltherefore first startsbashin a new process with theinit_file, then one of two things happens:execfor fish to "take over" the bash process, sourcingenv_filein the process.sourcethe file withenv_file.This logic should be possible to reuse for
xonshandzshas well, although someone more knowledgeable would need to clarify how to best perform the "take over" step for those shells.