feat: Relative path support in LockFile #4788
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fails right now since rattler_lock does not have the required version. |
* New `Verbatim` around some of the `UrlOrPath` * Handle base_dir on file open No behavior change is intended here.
... in uv_pep508 and pep508_rs.
... between pixi and uv.
hunger
force-pushed
the
push-wmptuwstlsln
branch
from
9367042 to
48c5dd8
Compare
|
Updated the change about adapting to rattler API changes. |
|
Maybe we can patch the rattler versions in this PR? So we can see if CI runs and then change it back after a rattler release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make pixi handle relative paths to pypi dependencies in the LockFile. This helps when checking in pixi.lock files that reference local python packages. Instead of ending up with a machine specific path in the lock file we have a relative path that should work for all developers.
This depends on the rattler part which is here: conda/rattler#1760
The PR consists of several changes:
LockFileconda/rattler#1760non-pep508-extensionsare enabled in pixi as wellNote: This only works with
pixi.log, not when storing the pixi configuration inline inpyproject.toml. Pyproject.toml will need to get an update to enable it to handle relative paths (like accept a work directory when parsing the file as well as non-pep508-extension support). I did not want to complicate this PR by requiring another PR to yet another crate.Relates to: #4680