chore: always enable stderr printing on verbose mode in the backends #4814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remimimimimi
force-pushed
the
chore/always-enable-stderr-printing-on-verbose-mode-in-the-backends
branch
from
e39d64e to
a21b891
Compare
remimimimimi
force-pushed
the
chore/always-enable-stderr-printing-on-verbose-mode-in-the-backends
branch
from
a21b891 to
fa64c80
Compare
|
Can we also do the same for the initialize? |
Strangely enough, it works already. |
nichmor
reviewed
Oct 25, 2025
| request: CondaOutputsParams, | ||
| output_stream: W, | ||
| ) -> Result<CondaOutputsResult, CommunicationError> { | ||
| // Capture all of stderr and discard it |
There was a problem hiding this comment.
I think this comment needs to be changed as we dont discard it anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically copied existing logic of
conda_buildprinting toconda_outputs