feat: add template args for env vars in tasks as well#5613
feat: add template args for env vars in tasks as well#5613tdejager wants to merge 2 commits intoprefix-dev:mainfrom
Conversation
0479745 to
720cddc
Compare
720cddc to
eec37dc
Compare
…strings-in-env-entries
| export.push_str(&format!("export \"{key}={value}\";\n")); | ||
| let rendered = value.render(context)?; | ||
| // Escape double quotes so the export statement remains valid shell. | ||
| let escaped = rendered.replace('"', "\\\""); |
There was a problem hiding this comment.
why it wasn't needed before?
There was a problem hiding this comment.
Yeah it should've been I think. Now I just reckoned it would happen more quickly.
|
Claude said: Missing test coverage (high priority):: There are no tests for the non-happy path.
The test coverage thing for non-happy path is fine I think. |
Description
Fixes #5446
How Has This Been Tested?
I tested this with the following toml:
AI Disclosure
Tools: Claude Code
Checklist:
schema/model.py.