feat: add expected-commit verification to git sources
#1978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the feature requested in issue prefix-dev#1895, adding an optional `expected-commit` field to git source configurations. Changes: - Added `expected_commit` field to GitSource struct in source.rs - Added GitCommitMismatch error variant to SourceError enum for structured error handling with expected, actual, and rev fields - Implemented verification logic in git_source.rs to compare actual commit against expected commit after checkout - Added comprehensive unit tests for serialization/deserialization - Added integration tests for both success and failure cases - Created test recipe demonstrating the feature - Updated documentation in recipe_file.md with usage examples The feature helps ensure security and reproducibility by detecting when a git tag or branch has been moved to point to a different commit than expected. Inspired by Wolfi/Melange. Closes prefix-dev#1895
baszalmstra
force-pushed
the
claude/issue-1895-fix-011CUrtSiPRXV2b8hgN64eFN
branch
from
6d5ef7d to
2e4484b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the feature requested in issue #1895, adding an optional
expected-commitfield to git source configurations.Changes:
expected_commitfield to GitSource struct in source.rsThe feature helps ensure security and reproducibility by detecting when a git tag or branch has been moved to point to a different commit than expected.
Closes #1895