Skip to content

feat(test): show executed commands for failing test scripts #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohitdebian wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(test): show executed commands for failing test scripts #2266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6b90d6d
feat(test): show executed commands for failing test scripts
mohitdebian Mar 5, 2026
eafb8e9
fix(test): avoid breaking interpreter detection when injecting set -x
mohitdebian Mar 5, 2026
6609125
fix(test): inject set -x only for bash/sh test scripts
mohitdebian Mar 5, 2026
c7ab2d7
fix(test): restrict set -x injection to unix bash test scripts
mohitdebian Mar 5, 2026
e206267
style: apply pre-commit formatting
mohitdebian Mar 5, 2026
d338260
refactor: run bash scripts with -x at interpreter level
mohitdebian Mar 15, 2026
5fba653
refactor(test): remove obsolete set -x injection logic
mohitdebian Mar 16, 2026
c51dee1
fix: remove debug logic and always run bash with -x
mohitdebian Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/rattler_build_core/src/package_test/run_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,6 +957,7 @@ async fn run_commands_test(
})?;

tracing::info!("Testing commands:");

commands_test
.script
.run_script(
Expand Down
2 changes: 1 addition & 1 deletion crates/rattler_build_script/src/interpreter/bash.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ impl Interpreter for BashInterpreter {
}

let build_script_path_str = build_script_path.to_string_lossy().to_string();
let cmd_args = vec!["bash", &build_script_path_str];
let cmd_args = vec!["bash", "-x", &build_script_path_str];

let output = run_process_with_replacements(
&cmd_args,
Expand Down