perf: track active requirement parents#187
Open
baszalmstra wants to merge 1 commit intoprefix-dev:mainfrom
Open
perf: track active requirement parents#187baszalmstra wants to merge 1 commit intoprefix-dev:mainfrom
baszalmstra wants to merge 1 commit intoprefix-dev:mainfrom
Conversation
Instead of iterating over all requires_clauses in decide(), maintain an IndexSet of variables that are assigned true and have requires clauses. This reduces the iteration scope to only relevant variables. Key changes: - Add active_requires_parents field to SolverState - Add track_decision_for_requires() free function for split borrows - Update decide() to iterate over active_requires_parents with lazy cleanup - Use index-based iteration with in-place swap_remove for stale entries
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Instead of iterating over all
requires_clausesindecide(), maintain anIndexSetof variables that are assigned true and have requires clauses. This reduces the iteration scope to only relevant variables. The idea is that this can make a big difference.