Fixes filters using an aliased value

[nickclark2016]

What does this PR do?

Fixes #2614

How does this PR change Premake's behavior?

No

Anything else we should know?

N/A

Did you check all the boxes?

• Focus on a single fix or feature; remove any unrelated formatting or code changes
• Add unit tests showing fix or feature works; all tests pass
• Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
• Follow our coding conventions
• Minimize the number of commits
• Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

[chrisant996]

Would it be worth adding a lowercase test?

[chrisant996]

Or better yet, a mixed case test, e.g. aRm64.

[nickclark2016]

We probably should, but that sort of test would be better fit elsewhere in the filter logic, not the VS logic.

[Jarod42]

It is now identical to vs200x_architectures.
It seems they can be regrouped, and so below function might be simplified.

[nickclark2016]

Keeping is separate in case any plugins are relying on this.

[Jarod42]

That pattern is repeated 3 times, maybe create a subfunction, something like:

function p.field.alias_resolved(key, value) do
  value = value:lower()
  local field = p.field.get(key)
  if field and field.aliases then
    local aliased = field.aliases[value]
	if aliased then
		value = tostring(aliased):lower()
	end
  end 
  return value
end

[nickclark2016]

These aren't quite the same. One is iterating over a table, one is a single value.

[chrisant996]

The pattern is identical in all three places, and can be factored to call the function Jarod42 suggested.

Here is what the 3 call sites would become:
(Edit 1: fixed . to : for calling the function.)
(Edit 2: oops, Jarod42 already handled the missing :lower() issue in criteria.lua and factored further than I had initially noticed, and I've updated the call sites below accordingly.)

context.lua

if type(value) == "table" then
	for i = 1, #value do
		value[i] = p.field:alias_resolved(key, value[i])
	end
elseif value ~= nil then
	value = p.field:alias_resolved(key, value)
end

criteria.lua

if prefix then
	word[1] = p.field:alias_resolved(prefix, word[1])
end

[nickclark2016]

Ah, misunderstood the comment

[chrisant996]

LGTM! (and you're right, my . was right the first time, not :)

[chrisant996]

Looks good to me, thanks for addressing this issue!