Fixed extension host termination issue#27
Merged
anand-presidio merged 3 commits intopresidio-oss:mainfrom Jan 28, 2025
magesh-presidio:bugfix/host-termination
Merged
Fixed extension host termination issue#27anand-presidio merged 3 commits intopresidio-oss:mainfrom magesh-presidio:bugfix/host-termination
anand-presidio merged 3 commits intopresidio-oss:mainfrom
magesh-presidio:bugfix/host-termination
Conversation
… as an empty to File Watcher
krithika7402
previously approved these changes
Jan 28, 2025
anand-presidio
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added validation for workspace folder path
After retrieving the workspace folder path, a condition is added to verify its presence. If the condition is met, the File Watcher is initialized, as passing an empty value to the File Watcher leads this issues.
Additionally, the codeIndexBackground function is brought under this condition, as invoking it without a valid workspace folder path serves no purpose.
Type of Change
Pre-flight Checklist
npm test) and code is formatted and linted (npm run format && npm run lint)