Skip to content

Fixed LLM and embedding validation occurs for every indexing update#31

Merged
anand-presidio merged 2 commits intopresidio-oss:mainfrom
magesh-presidio:bugfix/validation-on-index-update
Jan 29, 2025
Merged

Fixed LLM and embedding validation occurs for every indexing update#31
anand-presidio merged 2 commits intopresidio-oss:mainfrom
magesh-presidio:bugfix/validation-on-index-update

Conversation

@magesh-presidio
Copy link
Collaborator

Description

Replaced useEffect() with useDeepCompareEffect()

  • useDeepCompareEffect performs a deep equality check on dependencies, preventing effect re-runs when object references change but the content remains the same.
  • Validation now only occurs when the actual configuration values change, not during unrelated state updates.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update

Pre-flight Checklist

  • Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
  • Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint)
  • I have reviewed contributor guidelines

@anand-presidio anand-presidio merged commit d84f0d5 into presidio-oss:main Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LLM and embedding validation is occurring for every indexing update

2 participants