Enable Http Server with two https ports#60
Open
jingmeih wants to merge 1 commit intoprestodb:masterfrom
Open
Conversation
Enable http server with another alternative https port, this gives us the freedom that if the second port is needed.
|
@jingmeih Can we have the new code path under a flag so that we don't have to open 2 ports at the same time. |
Author
I added the flag on line(https://github.com/prestodb/airlift/pull/60/files#diff-1762da6fd46b87f7b857cf8ed43e4fe754589ef8f66ba0f4f79b0490d408b5acR188), let me know if this is not enough. |
tdcmeehan
reviewed
Dec 15, 2022
tdcmeehan
left a comment
tdcmeehan
left a comment
There was a problem hiding this comment.
Can two different certificates be used for the two different ports?
Author
The way I am thinking is to have two keystores, the additional keystore is for the new port. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are working on deprecating presto proxy in favor of proxygen. Proxygen uses a different certificate than presto proxy, in order to be compatible with our current presto proxy, we decide to listen to two HTTPS ports at the same time.
==TEST==