Skip to content

fix(client): parse Presto JSON response with custom reviver and BigInts #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 20, 2024
Merged

fix(client): parse Presto JSON response with custom reviver and BigInts #25

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b9ed52f
fix(client): parse Presto JSON response with custom reviver and BigInts
alonsovb Dec 18, 2024
797f9af
fix(client): improve big int parsing
alonsovb Dec 19, 2024
1b2a3b7
fix(client): check compatibility with check function
alonsovb Dec 19, 2024
c933c9e
refactor(client): move compatibility check to custom reviver
alonsovb Dec 20, 2024
9cbe8de
docs(readme): update readme to mention the BigInt parsing and precisi…
alonsovb Dec 20, 2024
d363dde
ci(nvm): use latest lts node version
alonsovb Dec 20, 2024
0564065
refactor(client): minor style changes
alonsovb Dec 20, 2024
02686b4
test(client): add some initial tests for the utility JSON parser
alonsovb Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.17.1
21.0.0
13 changes: 12 additions & 1 deletion presto-client/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ import {
Table,
} from './types'

function digitsToBigInt(_: string, value: unknown, { source }: { source: string }) {
return /^\d+$/.test(source) ? BigInt(source) : value
}

export class PrestoClient {
private baseUrl: string
private catalog?: string
Expand Down Expand Up @@ -270,7 +274,7 @@ export class PrestoClient {
throw new Error(`Query failed: ${JSON.stringify(await response.text())}`)
}

const prestoResponse = (await response.json()) as PrestoResponse
const prestoResponse = (await this.prestoConversionToJSON({ response })) as PrestoResponse
if (!prestoResponse) {
throw new Error(`Query failed with an empty response from the server.`)
}
Expand Down Expand Up @@ -334,6 +338,13 @@ export class PrestoClient {
method,
})
}

private async prestoConversionToJSON({ response }: { response: Response }): Promise<unknown> {
const text = await response.text()
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore JSON.parse with a 3 argument reviver is a stage 3 proposal with some support, allow it here.
return JSON.parse(text, digitsToBigInt)
}
}

export default PrestoClient
Loading