Skip to content

Add Windows path separator support. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Windows path separator support. #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/facebook/presto/maven/ServiceDescriptorGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ private List<Class<?>> findImplementationsOf(Class<?> implementationTemplate, UR
List<Class<?>> implementations = Lists.newArrayList();
List<String> classes = FileUtils.getFileNames(classesDirectory, "**/*.class", null, false);
for (String classPath : classes) {
String className = classPath.substring(0, classPath.length() - 6).replace('/', '.');
String className = classPath.substring(0, classPath.length() - 6).replace('/', '.').replace('\\', '.');
Copy link

@hgschmie hgschmie Feb 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make it more sense, instead of adding another replace to change the existing one into

.replace(File.separatorChar, '.')

which would work on any operating system?

Copy link
Contributor

@Megaprog Megaprog Apr 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look my pull request #11

try {
Class<?> implementation = searchRealm.loadClass(implementationTemplate.getName());
Class<?> clazz = searchRealm.loadClass(className);
Expand Down